Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: webkit/plugins/ppapi/quota_file_io.cc

Issue 7651002: Adding checks to guard against buffer overruns in QuotaFileIO::Write and base::FileUtilProxy::Write (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/quota_file_io.cc
===================================================================
--- webkit/plugins/ppapi/quota_file_io.cc (revision 96790)
+++ webkit/plugins/ppapi/quota_file_io.cc (working copy)
@@ -4,6 +4,8 @@
#include "webkit/plugins/ppapi/quota_file_io.h"
+#include <algorithm>
+
#include "base/stl_util.h"
#include "base/message_loop_proxy.h"
#include "base/task.h"
@@ -222,6 +224,8 @@
bool QuotaFileIO::Write(
int64_t offset, const char* buffer, int32_t bytes_to_write,
WriteCallback* callback) {
+ if (bytes_to_write <= 0)
+ return false;
WriteOperation* op = new WriteOperation(
this, false, offset, buffer, bytes_to_write, callback);
return RegisterOperationForQuotaChecks(op);

Powered by Google App Engine
This is Rietveld 408576698