Issue 7650027: Update Chromium to use new signature for

Issue 7650027: Update Chromium to use new signature for (Closed)

Created:
9 years, 4 months ago by Aaron Boodman

Modified:
9 years, 4 months ago

Reviewers:
jam, Matt Perry

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use new signature for WebFrameClient::didCreateIsolatedScriptContext(). BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97105

Patch Set 3 : respond to nits #

Patch Set 4 : more stuff #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -22 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View	1 2	2 chunks	+9 lines, -4 lines	0 comments	Download
M	chrome/renderer/extensions/event_bindings.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/event_bindings.cc	View	1	3 chunks	+7 lines, -8 lines	1 comment	Download
M	content/renderer/content_renderer_client.h	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	content/renderer/mock_content_renderer_client.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/renderer/mock_content_renderer_client.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/renderer/render_view.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	content/renderer/render_view.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm with nits http://codereview.chromium.org/7650027/diff/1/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): http://codereview.chromium.org/7650027/diff/1/chrome/renderer/chrome_content_renderer_client.cc#newcode81 chrome/renderer/chrome_content_renderer_client.cc:81: #include "v8/include/v8.h" I don't think this ...

9 years, 4 months ago (2011-08-15 22:04:56 UTC) #2

Aaron Boodman

Done. Matt, can you please review the chrome/ changes?

9 years, 4 months ago (2011-08-15 22:18:55 UTC) #3

Matt Perry

Nice! LGTM http://codereview.chromium.org/7650027/diff/5001/chrome/renderer/extensions/event_bindings.cc File chrome/renderer/extensions/event_bindings.cc (right): http://codereview.chromium.org/7650027/diff/5001/chrome/renderer/extensions/event_bindings.cc#newcode301 chrome/renderer/extensions/event_bindings.cc:301: // v8::Local<v8::Context> context = v8::Context::GetCurrent(); kill dead ...

9 years, 4 months ago (2011-08-15 22:22:18 UTC) #4

Matt Perry

9 years, 4 months ago (2011-08-15 22:22:18 UTC) #5

Nice! LGTM

http://codereview.chromium.org/7650027/diff/5001/chrome/renderer/extensions/e...
File chrome/renderer/extensions/event_bindings.cc (right):

http://codereview.chromium.org/7650027/diff/5001/chrome/renderer/extensions/e...
chrome/renderer/extensions/event_bindings.cc:301: // v8::Local<v8::Context>
context = v8::Context::GetCurrent();
kill dead code

Expand Messages | Collapse Messages