Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 7649030: Remove unnecessary prefs::kInstantEnabledOnce. (Closed)

Created:
9 years, 4 months ago by sreeram
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove unnecessary prefs::kInstantEnabledOnce. The Instant field trial only triggers when UMA reporting is enabled, so there's no need to set this preference anymore. BUG=none TEST=SearchProviderTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97229

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 chunk +0 lines, -4 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
sreeram
Please review.
9 years, 4 months ago (2011-08-15 21:42:15 UTC) #1
Peter Kasting
Rubber-stamp LGTM http://codereview.chromium.org/7649030/diff/1/chrome/browser/autocomplete/search_provider_unittest.cc File chrome/browser/autocomplete/search_provider_unittest.cc (left): http://codereview.chromium.org/7649030/diff/1/chrome/browser/autocomplete/search_provider_unittest.cc#oldcode157 chrome/browser/autocomplete/search_provider_unittest.cc:157: service->SetBoolean(prefs::kInstantEnabledOnce, true); Do other instances of this ...
9 years, 4 months ago (2011-08-15 21:46:49 UTC) #2
sreeram
http://codereview.chromium.org/7649030/diff/1/chrome/browser/autocomplete/search_provider_unittest.cc File chrome/browser/autocomplete/search_provider_unittest.cc (left): http://codereview.chromium.org/7649030/diff/1/chrome/browser/autocomplete/search_provider_unittest.cc#oldcode157 chrome/browser/autocomplete/search_provider_unittest.cc:157: service->SetBoolean(prefs::kInstantEnabledOnce, true); On 2011/08/15 21:46:49, Peter Kasting wrote: > ...
9 years, 4 months ago (2011-08-15 22:54:48 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-17 22:34:40 UTC) #4
Change committed as 97229

Powered by Google App Engine
This is Rietveld 408576698