Print Preview: Always enable the internal PDF plugin for print preview.

content/browser/plugin_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/plugin_service.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/threading/thread.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "content/browser/browser_thread.h"
 #include "content/browser/content_browser_client.h"
 #include "content/browser/ppapi_plugin_process_host.h"
 #include "content/browser/renderer_host/render_process_host.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/resource_context.h"
 #include "content/common/content_notification_types.h"
 #include "content/common/content_switches.h"
 #include "content/common/notification_service.h"
 #include "content/common/pepper_plugin_registry.h"
 #include "content/common/plugin_messages.h"
+#include "content/common/url_constants.h"
 #include "content/common/view_messages.h"
 #include "webkit/plugins/npapi/plugin_constants_win.h"
 #include "webkit/plugins/npapi/plugin_list.h"
 #include "webkit/plugins/webplugininfo.h"
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
 using ::base::files::FilePathWatcher;
 #endif
 
 #if defined(OS_MACOSX)
@@ skipping 315 matching lines @@
                                   webkit::WebPluginInfo* info,
                                   std::string* actual_mime_type) {
   // GetPluginInfoArray may need to load the plugins, so we need to be
   // on the FILE thread.
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
   {
     base::AutoLock auto_lock(overridden_plugins_lock_);
     for (size_t i = 0; i < overridden_plugins_.size(); ++i) {
       if (overridden_plugins_[i].render_process_id == render_process_id &&
           overridden_plugins_[i].render_view_id == render_view_id &&
-          overridden_plugins_[i].url == url) {
+          (overridden_plugins_[i].url == url ||
+           url.SchemeIs(chrome::kChromeUIScheme))) {

[jam, 2011/08/15 22:03:04]

I believe you're doing this because the url for the pdf changes depending on the
print settings. but this doesn't match the concept of overriding a plugin for a
url. it looks like you're just reusing that code, but changing the behavior
(since now any overriden plugin applies for any chrome ui url)

perhaps you want to change the documentation for OverriddenPlugin so that if
passed in url is empty, it applies to all urls in that tab?

[Lei Zhang, 2011/08/16 00:16:41]

Done

         if (actual_mime_type)
           *actual_mime_type = mime_type;
         *info = overridden_plugins_[i].plugin;
         return true;
       }
     }
   }
   bool allow_wildcard = true;
   std::vector<webkit::WebPluginInfo> plugins;
   std::vector<std::string> mime_types;
@@ skipping 106 matching lines @@
     webkit::npapi::PluginList::Singleton()->RegisterInternalPlugin(
         ppapi_plugins_[i].ToWebPluginInfo());
   }
 }
 
 // There should generally be very few plugins so a brute-force search is fine.
 PepperPluginInfo* PluginService::GetRegisteredPpapiPluginInfo(
     const FilePath& plugin_path) {
   PepperPluginInfo* info = NULL;
   for (size_t i = 0; i < ppapi_plugins_.size(); i++) {
-   if (ppapi_plugins_[i].path == plugin_path) {
-     info = &ppapi_plugins_[i];
-     break;
-   }
+    if (ppapi_plugins_[i].path == plugin_path) {
+      info = &ppapi_plugins_[i];
+      break;
+    }
   }
   return info;
 }
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
 // static
 void PluginService::RegisterFilePathWatcher(
     FilePathWatcher *watcher,
     const FilePath& path,
     FilePathWatcher::Delegate* delegate) {
   bool result = watcher->Watch(path, delegate);
   DCHECK(result);
 }
 #endif