Fix query string unescaping.

FormatURL used to escape characters in the query string that
GURL doesn't escape when cannonicalizing, and are illegal
in the query portion of the URL according to spec.  Fix that
behavior, so if gurl is a valid url, so is GURL(FormatURL(gurl)).

BUG=90387
TEST=NetUtilTest.FormatUrlRoundTripPathASCII, NetUtilTest.FormatUrlRoundTripPathEscape, NetUtilTest.FormatUrlRoundTripQueryASCII, NetUtilTest.FormatUrlRoundTripQueryEscaped

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97093

[mmenke, 2011-08-16 19:29:39]

In order to have GURL(FormatURL(gurl)) == gurl, we'd have to stop unescaping all
ASCII characters in the query string, which I don't think we want to do.  This
CL achieves the weaker goal of if gurl is a valid url, according to spec,
GURL(FormatURL(gurl)) will be, too.

As a result, there are still cases where refreshing a page will request a
different url than the original request.

[brettw, 2011-08-16 20:56:45]

LGTM, although I'm not a net reviewer.

[mmenke, 2011-08-16 21:07:47]

Thanks for pointing that out.

[+willchan]

On 2011/08/16 20:56:45, brettw wrote:
> LGTM, although I'm not a net reviewer.

[willchan no longer on Chromium, 2011-08-16 21:59:16]

mmenke is in net/OWNERS, so if he's gotten a review, it's fine.

that said, i also looked and it LGTM

[mmenke, 2011-08-16 22:01:55]

On 2011/08/16 21:59:16, willchan wrote:
> mmenke is in net/OWNERS, so if he's gotten a review, it's fine.
> 
> that said, i also looked and it LGTM

Thanks.  Wasn't sure if I counted as an owner for the purposes of a review of my
own code or not.

[commit-bot: I haz the power, 2011-08-17 03:34:40]

Change committed as 97093