Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 7649013: Disabled UserControllerTest (Closed)

Created:
9 years, 4 months ago by whywhat
Modified:
9 years, 4 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disabled UserControllerTest R=timurrrr@chromium.org BUG=92871 TEST=Verify that UserControllerTest doesn't run on buildbots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/chromeos/login/user_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
whywhat
9 years, 4 months ago (2011-08-15 11:53:47 UTC) #1
Timur Iskhodzhanov
LGTM
9 years, 4 months ago (2011-08-15 11:54:36 UTC) #2
Paweł Hajdan Jr.
9 years, 4 months ago (2011-08-15 17:27:18 UTC) #3
Thank you for dealing with test failures. Please read
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/han...
full reference how to do that.

Especially, please remember about:
- filing a bug about the issue, *and using Tests-Disabled, Tests-Fails,
Tests-Flaky label*
- copy-pasting the failure logs into the bug (buildbot links become stale
quickly)
- adding a link to the bug as a comment above the test

Thanks!

*(this is a canned response, I hope you don't mind too much; I think these
guidelines really help us track test failures better)*

On Mon, Aug 15, 2011 at 04:53, <avayvod@chromium.org> wrote:

> Reviewers: Timur Iskhodzhanov,
>
> Description:
> Disabled UserControllerTest
>
> R=timurrrr@chromium.org
> BUG=92871
> TEST=Verify that UserControllerTest doesn't run on buildbots.
>
>
> Please review this at
http://codereview.chromium.**org/7649013/<http://codereview.chromium.org/7649...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/chromeos/login/**user_controller_unittest.cc
>
>
> Index: chrome/browser/chromeos/login/**user_controller_unittest.cc
> diff --git a/chrome/browser/chromeos/**login/user_controller_**unittest.cc
> b/chrome/browser/chromeos/**login/user_controller_**unittest.cc
> index 5f18414373c15d8e7f102783337982**7d00acde6e..**
> 775088af7824ecde241118363fdbb2**875974a131 100644
> --- a/chrome/browser/chromeos/**login/user_controller_**unittest.cc
> +++ b/chrome/browser/chromeos/**login/user_controller_**unittest.cc
> @@ -12,7 +12,8 @@
>
>  namespace chromeos {
>
> -TEST(UserControllerTest, GetNameTooltip) {
> +// See http://crbug.com/92871 for details.
> +TEST(UserControllerTest, DISABLED_GetNameTooltip) {
>   UserController guest_user_controller(NULL, false);
>   EXPECT_EQ(UTF16ToWide(l10n_**util::GetStringUTF16(IDS_ADD_**USER)),
>             guest_user_controller.**GetNameTooltip());
>
>
>

Powered by Google App Engine
This is Rietveld 408576698