Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9478)

Unified Diff: chrome/common/json_pref_store_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_set_unittest.cc ('k') | chrome/common/json_schema_validator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/json_pref_store_unittest.cc
diff --git a/chrome/common/json_pref_store_unittest.cc b/chrome/common/json_pref_store_unittest.cc
index 3330007f6580cec6bf990c75988e26bbf12ba6b3..f8074d28e038c45064043316e67f1fffff4e302c 100644
--- a/chrome/common/json_pref_store_unittest.cc
+++ b/chrome/common/json_pref_store_unittest.cc
@@ -113,7 +113,7 @@ void RunBasicJsonPrefStoreTest(JsonPrefStore *pref_store,
FilePath some_path(FILE_PATH_LITERAL("/usr/sbin/"));
pref_store->SetValue(kSomeDirectory,
- Value::CreateStringValue(some_path.value()));
+ base::StringValue::New(some_path.value()));
EXPECT_EQ(PrefStore::READ_OK, pref_store->GetValue(kSomeDirectory, &actual));
EXPECT_TRUE(actual->GetAsString(&path));
EXPECT_EQ(some_path.value(), path);
@@ -125,8 +125,7 @@ void RunBasicJsonPrefStoreTest(JsonPrefStore *pref_store,
EXPECT_TRUE(actual->GetAsBoolean(&boolean));
EXPECT_TRUE(boolean);
- pref_store->SetValue(kNewWindowsInTabs,
- Value::CreateBooleanValue(false));
+ pref_store->SetValue(kNewWindowsInTabs, base::FalseValue());
EXPECT_EQ(PrefStore::READ_OK,
pref_store->GetValue(kNewWindowsInTabs, &actual));
EXPECT_TRUE(actual->GetAsBoolean(&boolean));
@@ -136,13 +135,13 @@ void RunBasicJsonPrefStoreTest(JsonPrefStore *pref_store,
int integer = 0;
EXPECT_TRUE(actual->GetAsInteger(&integer));
EXPECT_EQ(20, integer);
- pref_store->SetValue(kMaxTabs, Value::CreateIntegerValue(10));
+ pref_store->SetValue(kMaxTabs, base::NumberValue::New(10));
EXPECT_EQ(PrefStore::READ_OK, pref_store->GetValue(kMaxTabs, &actual));
EXPECT_TRUE(actual->GetAsInteger(&integer));
EXPECT_EQ(10, integer);
pref_store->SetValue(kLongIntPref,
- Value::CreateStringValue(
+ base::StringValue::New(
base::Int64ToString(214748364842LL)));
EXPECT_EQ(PrefStore::READ_OK, pref_store->GetValue(kLongIntPref, &actual));
EXPECT_TRUE(actual->GetAsString(&string_value));
« no previous file with comments | « chrome/common/extensions/extension_set_unittest.cc ('k') | chrome/common/json_schema_validator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698