Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/ui/webui/options/advanced_options_handler.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/advanced_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/advanced_options_handler.cc b/chrome/browser/ui/webui/options/advanced_options_handler.cc
index dce0eadbf31ba4d20e81ab2f4d1fd9a6de269cc5..733c56f778e4ca9bab3d94809337445e3e7c7939 100644
--- a/chrome/browser/ui/webui/options/advanced_options_handler.cc
+++ b/chrome/browser/ui/webui/options/advanced_options_handler.cc
@@ -455,7 +455,7 @@ void AdvancedOptionsHandler::HandleBackgroundModeCheckbox(
}
void AdvancedOptionsHandler::SetupBackgroundModeSettings() {
- base::FundamentalValue checked(background_mode_enabled_.GetValue());
+ base::BooleanValue checked(background_mode_enabled_.GetValue());
web_ui_->CallJavascriptFunction(
"options.AdvancedOptions.SetBackgroundModeCheckboxState", checked);
}
@@ -521,14 +521,14 @@ void AdvancedOptionsHandler::SetupCloudPrintProxySection() {
bool cloud_print_proxy_allowed =
!cloud_print_proxy_enabled_.IsManaged() ||
cloud_print_proxy_enabled_.GetValue();
- base::FundamentalValue allowed(cloud_print_proxy_allowed);
+ base::BooleanValue allowed(cloud_print_proxy_allowed);
std::string email;
if (profile->GetPrefs()->HasPrefPath(prefs::kCloudPrintEmail) &&
cloud_print_proxy_allowed) {
email = profile->GetPrefs()->GetString(prefs::kCloudPrintEmail);
}
- base::FundamentalValue disabled(email.empty());
+ base::BooleanValue disabled(email.empty());
string16 label_str;
if (email.empty()) {
@@ -554,8 +554,8 @@ void AdvancedOptionsHandler::RemoveCloudPrintProxySection() {
void AdvancedOptionsHandler::SetupMetricsReportingCheckbox() {
#if defined(GOOGLE_CHROME_BUILD) && !defined(OS_CHROMEOS)
- base::FundamentalValue checked(enable_metrics_recording_.GetValue());
- base::FundamentalValue disabled(enable_metrics_recording_.IsManaged());
+ base::BooleanValue checked(enable_metrics_recording_.GetValue());
+ base::BooleanValue disabled(enable_metrics_recording_.IsManaged());
web_ui_->CallJavascriptFunction(
"options.AdvancedOptions.SetMetricsReportingCheckboxState", checked,
disabled);
@@ -566,7 +566,7 @@ void AdvancedOptionsHandler::SetupMetricsReportingSettingVisibility() {
#if defined(GOOGLE_CHROME_BUILD) && defined(OS_CHROMEOS)
// Don't show the reporting setting if we are in the guest mode.
if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kGuestSession)) {
- base::FundamentalValue visible(false);
+ base::BooleanValue visible(false);
web_ui_->CallJavascriptFunction(
"options.AdvancedOptions.SetMetricsReportingSettingVisibility",
visible);
@@ -576,7 +576,7 @@ void AdvancedOptionsHandler::SetupMetricsReportingSettingVisibility() {
void AdvancedOptionsHandler::SetupFontSizeLabel() {
// We're only interested in integer values, so convert to int.
- base::FundamentalValue font_size(default_font_size_.GetValue());
+ base::NumberValue font_size(default_font_size_.GetValue());
web_ui_->CallJavascriptFunction(
"options.AdvancedOptions.SetFontSize", font_size);
}
@@ -586,18 +586,18 @@ void AdvancedOptionsHandler::SetupDownloadLocationPath() {
// In case allow_file_selection_dialogs_ is false, we will not display any
// file-selection dialogs but show an InfoBar. That is why we can disable
// the DownloadLocationPath-Chooser right-away.
- base::FundamentalValue disabled(default_download_location_.IsManaged() ||
+ base::BooleanValue disabled(default_download_location_.IsManaged() ||
!allow_file_selection_dialogs_.GetValue());
web_ui_->CallJavascriptFunction(
"options.AdvancedOptions.SetDownloadLocationPath", value, disabled);
}
void AdvancedOptionsHandler::SetupPromptForDownload() {
- base::FundamentalValue checked(ask_for_save_location_.GetValue());
+ base::BooleanValue checked(ask_for_save_location_.GetValue());
// If either the DownloadDirectory is managed or if file-selection dialogs are
// disallowed then |ask_for_save_location_| must currently be false and cannot
// be changed.
- base::FundamentalValue disabled(default_download_location_.IsManaged() ||
+ base::BooleanValue disabled(default_download_location_.IsManaged() ||
!allow_file_selection_dialogs_.GetValue());
web_ui_->CallJavascriptFunction(
"options.AdvancedOptions.SetPromptForDownload", checked, disabled);
@@ -609,7 +609,7 @@ void AdvancedOptionsHandler::SetupAutoOpenFileTypesDisabledAttribute() {
DownloadManager* manager =
web_ui_->tab_contents()->browser_context()->GetDownloadManager();
bool disabled = !(manager && manager->download_prefs()->IsAutoOpenUsed());
- base::FundamentalValue value(disabled);
+ base::BooleanValue value(disabled);
web_ui_->CallJavascriptFunction(
"options.AdvancedOptions.SetAutoOpenFileTypesDisabledAttribute", value);
}
@@ -623,7 +623,7 @@ void AdvancedOptionsHandler::SetupProxySettingsSection() {
bool is_extension_controlled = (proxy_config &&
proxy_config->IsExtensionControlled());
- base::FundamentalValue disabled(proxy_prefs_->IsManaged() ||
+ base::BooleanValue disabled(proxy_prefs_->IsManaged() ||
is_extension_controlled);
// Get the appropriate info string to describe the button.
@@ -642,21 +642,21 @@ void AdvancedOptionsHandler::SetupProxySettingsSection() {
void AdvancedOptionsHandler::SetupSSLConfigSettings() {
{
- base::FundamentalValue checked(rev_checking_enabled_.GetValue());
- base::FundamentalValue disabled(rev_checking_enabled_.IsManaged());
+ base::BooleanValue checked(rev_checking_enabled_.GetValue());
+ base::BooleanValue disabled(rev_checking_enabled_.IsManaged());
web_ui_->CallJavascriptFunction(
"options.AdvancedOptions.SetCheckRevocationCheckboxState", checked,
disabled);
}
{
- base::FundamentalValue checked(ssl3_enabled_.GetValue());
- base::FundamentalValue disabled(ssl3_enabled_.IsManaged());
+ base::BooleanValue checked(ssl3_enabled_.GetValue());
+ base::BooleanValue disabled(ssl3_enabled_.IsManaged());
web_ui_->CallJavascriptFunction(
"options.AdvancedOptions.SetUseSSL3CheckboxState", checked, disabled);
}
{
- base::FundamentalValue checked(tls1_enabled_.GetValue());
- base::FundamentalValue disabled(tls1_enabled_.IsManaged());
+ base::BooleanValue checked(tls1_enabled_.GetValue());
+ base::BooleanValue disabled(tls1_enabled_.IsManaged());
web_ui_->CallJavascriptFunction(
"options.AdvancedOptions.SetUseTLS1CheckboxState", checked, disabled);
}
« no previous file with comments | « chrome/browser/ui/webui/ntp/shown_sections_handler.cc ('k') | chrome/browser/ui/webui/options/autofill_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698