Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2205)

Unified Diff: chrome/browser/sync/engine/syncapi.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/syncapi.cc
diff --git a/chrome/browser/sync/engine/syncapi.cc b/chrome/browser/sync/engine/syncapi.cc
index 408f71ce70917b5a3eb24fe018e7bffad01afd63..c59479e0c429a917bc419a2b5fc597f37a09fb68 100644
--- a/chrome/browser/sync/engine/syncapi.cc
+++ b/chrome/browser/sync/engine/syncapi.cc
@@ -1180,7 +1180,7 @@ DictionaryValue* SyncManager::ChangeRecord::ToValue(
}
if (!node_value) {
NOTREACHED();
- node_value = Value::CreateNullValue();
+ node_value = base::NullValue();
}
value->Set("node", node_value);
return value;
@@ -2751,7 +2751,7 @@ JsArgList SyncManager::SyncInternal::GetNotificationState(
const JsArgList& args) {
bool notifications_enabled = allstatus_.status().notifications_enabled;
ListValue return_args;
- return_args.Append(Value::CreateBooleanValue(notifications_enabled));
+ return_args.Append(base::BooleanValue::New(notifications_enabled));
return JsArgList(&return_args);
}
@@ -2837,7 +2837,7 @@ JsArgList SyncManager::SyncInternal::GetChildNodeIds(
id, &child_handles);
for (syncable::Directory::ChildHandles::const_iterator it =
child_handles.begin(); it != child_handles.end(); ++it) {
- child_ids->Append(Value::CreateStringValue(
+ child_ids->Append(base::StringValue::New(
base::Int64ToString(*it)));
}
}
@@ -2869,7 +2869,7 @@ JsArgList SyncManager::SyncInternal::FindNodesContainingString(
for (std::vector<const syncable::EntryKernel*>::const_iterator it =
entry_kernels.begin(); it != entry_kernels.end(); ++it) {
if ((*it)->ContainsString(lowercase_query)) {
- result->Append(new StringValue(base::Int64ToString(
+ result->Append(base::StringValue::New(base::Int64ToString(
(*it)->ref(syncable::META_HANDLE))));
}
}
@@ -2887,7 +2887,7 @@ void SyncManager::SyncInternal::OnNotificationStateChange(
}
if (js_event_handler_.IsInitialized()) {
DictionaryValue details;
- details.Set("enabled", Value::CreateBooleanValue(notifications_enabled));
+ details.Set("enabled", base::BooleanValue::New(notifications_enabled));
js_event_handler_.Call(FROM_HERE,
&JsEventHandler::HandleJsEvent,
"onNotificationStateChange",
@@ -2929,7 +2929,7 @@ void SyncManager::SyncInternal::OnIncomingNotification(
it != type_payloads.end(); ++it) {
const std::string& model_type_str =
syncable::ModelTypeToString(it->first);
- changed_types->Append(Value::CreateStringValue(model_type_str));
+ changed_types->Append(base::StringValue::New(model_type_str));
}
js_event_handler_.Call(FROM_HERE,
&JsEventHandler::HandleJsEvent,
« no previous file with comments | « chrome/browser/search_engines/template_url_service_unittest.cc ('k') | chrome/browser/sync/engine/syncapi_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698