Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: chrome/browser/extensions/extension_tts_engine_api.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tts_engine_api.cc
diff --git a/chrome/browser/extensions/extension_tts_engine_api.cc b/chrome/browser/extensions/extension_tts_engine_api.cc
index fe845932c9a3049b49306352dcc194402dac4a4e..1be9d532c7e986e0a4b7dccfacaeb4a7eebf61ab 100644
--- a/chrome/browser/extensions/extension_tts_engine_api.cc
+++ b/chrome/browser/extensions/extension_tts_engine_api.cc
@@ -58,15 +58,15 @@ void GetExtensionVoices(Profile* profile, ListValue* result_voices) {
voice.event_types.begin();
iter != voice.event_types.end();
++iter) {
- event_types->Append(Value::CreateStringValue(*iter));
+ event_types->Append(base::StringValue::New(*iter));
}
// If the extension sends end events, the controller will handle
// queueing and send interrupted and cancelled events.
if (voice.event_types.find(constants::kEventTypeEnd) !=
voice.event_types.end()) {
event_types->Append(
- Value::CreateStringValue(constants::kEventTypeCancelled));
- event_types->Append(Value::CreateStringValue(
+ base::StringValue::New(constants::kEventTypeCancelled));
+ event_types->Append(base::StringValue::New(
constants::kEventTypeInterrupted));
}
@@ -160,7 +160,7 @@ void ExtensionTtsEngineSpeak(Utterance* utterance,
(event_types.find(constants::kEventTypeEnd) != event_types.end());
ListValue args;
- args.Set(0, Value::CreateStringValue(utterance->text()));
+ args.Set(0, base::StringValue::New(utterance->text()));
// Pass through most options to the speech engine, but remove some
// that are handled internally.
@@ -178,7 +178,7 @@ void ExtensionTtsEngineSpeak(Utterance* utterance,
options->Remove(constants::kIsFinalEventKey, NULL);
args.Set(1, options);
- args.Set(2, Value::CreateIntegerValue(utterance->id()));
+ args.Set(2, base::NumberValue::New(utterance->id()));
std::string json_args;
base::JSONWriter::Write(&args, false, &json_args);

Powered by Google App Engine
This is Rietveld 408576698