Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: chrome/browser/extensions/extension_sidebar_api.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_sidebar_api.cc
diff --git a/chrome/browser/extensions/extension_sidebar_api.cc b/chrome/browser/extensions/extension_sidebar_api.cc
index e9a209dfcf922be06940ab3b05a3dce487b8f01d..bffe6602a8c851b8f083d7b8822c45ea0b5e6bdd 100644
--- a/chrome/browser/extensions/extension_sidebar_api.cc
+++ b/chrome/browser/extensions/extension_sidebar_api.cc
@@ -58,8 +58,8 @@ void ExtensionSidebarEventRouter::OnStateChanged(
const std::string& state) {
int tab_id = ExtensionTabUtil::GetTabId(tab);
DictionaryValue* details = new DictionaryValue;
- details->Set(kTabIdKey, Value::CreateIntegerValue(tab_id));
- details->Set(kStateKey, Value::CreateStringValue(state));
+ details->Set(kTabIdKey, base::NumberValue::New(tab_id));
+ details->Set(kStateKey, base::StringValue::New(state));
ListValue args;
args.Set(0, details);
@@ -190,7 +190,7 @@ bool GetStateSidebarFunction::RunImpl(TabContents* tab,
extension_sidebar_constants::kShownState;
}
- result_.reset(Value::CreateStringValue(result));
+ result_.reset(base::StringValue::New(result));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698