Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1716)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 5111f31b9f6c4cf061e5db5baecb05140b7c5a87..3e04ae711b11ad1636a29fbcd0981a9cd82a032e 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -854,7 +854,7 @@ class ExtensionServiceTest
msg += " = ";
msg += base::IntToString(value);
- SetPref(extension_id, pref_path, Value::CreateIntegerValue(value), msg);
+ SetPref(extension_id, pref_path, base::NumberValue::New(value), msg);
}
void SetPrefBool(const std::string& extension_id,
@@ -865,7 +865,7 @@ class ExtensionServiceTest
msg += " = ";
msg += (value ? "true" : "false");
- SetPref(extension_id, pref_path, Value::CreateBooleanValue(value), msg);
+ SetPref(extension_id, pref_path, base::BooleanValue::New(value), msg);
}
void ClearPref(const std::string& extension_id,
@@ -891,7 +891,7 @@ class ExtensionServiceTest
ListValue* list_value = new ListValue();
for (std::set<std::string>::const_iterator iter = value.begin();
iter != value.end(); ++iter)
- list_value->Append(Value::CreateStringValue(*iter));
+ list_value->Append(base::StringValue::New(*iter));
SetPref(extension_id, pref_path, list_value, msg);
}
@@ -1500,7 +1500,7 @@ TEST_F(ExtensionServiceTest, GrantedAPIAndHostPermissions) {
ListValue* api_permissions = new ListValue();
api_permissions->Append(
- Value::CreateIntegerValue(ExtensionAPIPermission::kTab));
+ base::NumberValue::New(ExtensionAPIPermission::kTab));
SetPref(extension_id, "granted_permissions.api",
api_permissions, "granted_permissions.api");
SetPrefStringSet(
@@ -2494,7 +2494,7 @@ TEST_F(ExtensionServiceTest, BlacklistedByPolicyWillNotInstall) {
ListPrefUpdate update(profile_->GetPrefs(),
prefs::kExtensionInstallDenyList);
ListValue* blacklist = update.Get();
- blacklist->Append(Value::CreateStringValue("*"));
+ blacklist->Append(base::StringValue::New("*"));
}
// Blacklist prevents us from installing good_crx.
@@ -2508,7 +2508,7 @@ TEST_F(ExtensionServiceTest, BlacklistedByPolicyWillNotInstall) {
ListPrefUpdate update(profile_->GetPrefs(),
prefs::kExtensionInstallAllowList);
ListValue* whitelist = update.Get();
- whitelist->Append(Value::CreateStringValue(good_crx));
+ whitelist->Append(base::StringValue::New(good_crx));
}
@@ -2535,7 +2535,7 @@ TEST_F(ExtensionServiceTest, BlacklistedByPolicyRemovedIfRunning) {
ASSERT_TRUE(blacklist != NULL);
// Blacklist this extension.
- blacklist->Append(Value::CreateStringValue(good_crx));
+ blacklist->Append(base::StringValue::New(good_crx));
prefs->ScheduleSavePersistentPrefs();
}
« no previous file with comments | « chrome/browser/extensions/extension_rlz_module.cc ('k') | chrome/browser/extensions/extension_settings_storage_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698