Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2006)

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/testing_automation_provider.cc
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc
index ff6b7de8888343b684fb09eadfc9711bc4e2f59c..10b8a86081c947fee312ed7766aa85a9dfbc1066 100644
--- a/chrome/browser/automation/testing_automation_provider.cc
+++ b/chrome/browser/automation/testing_automation_provider.cc
@@ -2517,13 +2517,13 @@ ListValue* TestingAutomationProvider::GetInfobarsInfo(TabContents* tc) {
ListValue* buttons_list = new ListValue;
int buttons = confirm_infobar->GetButtons();
if (buttons & ConfirmInfoBarDelegate::BUTTON_OK) {
- StringValue* button_label = new StringValue(
+ StringValue* button_label = base::StringValue::New(
confirm_infobar->GetButtonLabel(
ConfirmInfoBarDelegate::BUTTON_OK));
buttons_list->Append(button_label);
}
if (buttons & ConfirmInfoBarDelegate::BUTTON_CANCEL) {
- StringValue* button_label = new StringValue(
+ StringValue* button_label = base::StringValue::New(
confirm_infobar->GetButtonLabel(
ConfirmInfoBarDelegate::BUTTON_CANCEL));
buttons_list->Append(button_label);
@@ -3429,7 +3429,7 @@ void TestingAutomationProvider::GetPluginsInfo(
type_it->file_extensions.begin();
ext_it != type_it->file_extensions.end();
++ext_it) {
- file_extensions->Append(new StringValue(*ext_it));
+ file_extensions->Append(base::StringValue::New(*ext_it));
}
mime_type->Set("fileExtensions", file_extensions);
@@ -4133,7 +4133,7 @@ ListValue* GetHostPermissions(const Extension* ext, bool effective_perm) {
ListValue* permissions = new ListValue;
for (URLPatternSet::const_iterator perm = pattern_set.begin();
perm != pattern_set.end(); ++perm) {
- permissions->Append(new StringValue(perm->GetAsString()));
+ permissions->Append(base::StringValue::New(perm->GetAsString()));
}
return permissions;
@@ -4145,7 +4145,7 @@ ListValue* GetAPIPermissions(const Extension* ext) {
ext->GetActivePermissions()->GetAPIsAsStrings();
for (std::set<std::string>::const_iterator perm = perm_list.begin();
perm != perm_list.end(); ++perm) {
- permissions->Append(new StringValue(perm->c_str()));
+ permissions->Append(base::StringValue::New(perm->c_str()));
}
return permissions;
}
@@ -4560,7 +4560,7 @@ void TestingAutomationProvider::GetSyncInfo(Browser* browser,
for (syncable::ModelTypeSet::iterator it = synced_datatypes.begin();
it != synced_datatypes.end(); ++it) {
synced_datatype_list->Append(
- new StringValue(syncable::ModelTypeToString(*it)));
+ base::StringValue::New(syncable::ModelTypeToString(*it)));
}
sync_info->Set("synced datatypes", synced_datatype_list);
}
@@ -4790,7 +4790,7 @@ ListValue* TestingAutomationProvider::GetListFromAutofillProfiles(
value_it != value_list.end(); ++value_it) {
string16 value = *value_it;
if (value.length()) // If there was something stored for that value.
- values_to_return->Append(new StringValue(value));
+ values_to_return->Append(base::StringValue::New(value));
}
if (!values_to_return->empty())
profile_info->Set(type_it->second, values_to_return);
@@ -5899,7 +5899,7 @@ void TestingAutomationProvider::GetTabIds(
for (int i = 0; i < browser->tab_count(); ++i) {
int id = browser->GetTabContentsWrapperAt(i)->restore_tab_helper()->
session_id().id();
- id_list->Append(Value::CreateIntegerValue(id));
+ id_list->Append(base::NumberValue::New(id));
}
}
DictionaryValue dict;

Powered by Google App Engine
This is Rietveld 408576698