fix build break (missing file in IAccessible2Proxy)

fix build break (missing file in IAccessible2Proxy)

I removed the _p.c files from the associated iaccessible2 previously to fix windows incremental link, but didn't add the required _p.c one to the proxy dll.

BUG=Red tree
TEST=IAccessible2Proxy links

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96675

[Ryan Sleevi, 2011-08-13 03:44:57]

http://codereview.chromium.org/7649003/diff/1/third_party/iaccessible2/iacces...
File third_party/iaccessible2/iaccessible2.gyp (right):

http://codereview.chromium.org/7649003/diff/1/third_party/iaccessible2/iacces...
third_party/iaccessible2/iaccessible2.gyp:41:
'<(INTERMEDIATE_DIR)/../iaccessible2/ia2_api_all_p.c',
is _p.c generated by this target? Or is it still generated by ia2_api_all.idl?

If so, you should be using <(SHARED_INTERMEDIATE_DIR) to share files across
targets. <(INTERMEDIATE_DIR) is gyp-target-specific.

[scottmg, 2011-08-13 03:50:02]

On 2011/08/13 03:44:57, Ryan Sleevi wrote:
>
http://codereview.chromium.org/7649003/diff/1/third_party/iaccessible2/iacces...
> File third_party/iaccessible2/iaccessible2.gyp (right):
> 
>
http://codereview.chromium.org/7649003/diff/1/third_party/iaccessible2/iacces...
> third_party/iaccessible2/iaccessible2.gyp:41:
> '<(INTERMEDIATE_DIR)/../iaccessible2/ia2_api_all_p.c',
> is _p.c generated by this target? Or is it still generated by ia2_api_all.idl?
> 
> If so, you should be using <(SHARED_INTERMEDIATE_DIR) to share files across
> targets. <(INTERMEDIATE_DIR) is gyp-target-specific.

Oh dear. I'll have to parse the gyp-dev link you sent me more carefully.
dlldata.c is also generated by the .idl I think so I guess that build file is
already "wrong" then?

[Ryan Sleevi, 2011-08-13 03:52:10]

Yup. This LGTM as-is, since this is an existing issue. Can you file a bug to
follow-up on this?

The gyp-dev link is
http://groups.google.com/group/gyp-developer/browse_thread/thread/c5c2193d77f...
for reference.

This cheats a little in that it assumes that the .idl will be spit into a
specific path, which isn't an assumption that is supposed to be made with
<(INTERMEDIATE_DIR). Unfortunately, this isn't the only place in Chrome code
that makes that assumption either.

[scottmg, 2011-08-13 03:57:06]

On 2011/08/13 03:52:10, Ryan Sleevi wrote:
> Can you file a bug to follow-up on this?

Done, http://code.google.com/p/chromium/issues/detail?id=92755

Thanks Ryan.