content/browser/accessibility/browser_accessibility_manager.cc - Issue 7648055: Add DCHECK to BrowserAccessibilityManager::Remove to detect undefined behavoir that may lead to a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager.cc

Issue 7648055: Add DCHECK to BrowserAccessibilityManager::Remove to detect undefined behavoir that may lead to a... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/accessibility/browser_accessibility_manager_unittest.cc ('K') | « chrome/browser/accessibility/browser_accessibility_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager.cc

===================================================================

--- content/browser/accessibility/browser_accessibility_manager.cc (revision 96997)

+++ content/browser/accessibility/browser_accessibility_manager.cc (working copy)

@@ -116,6 +116,9 @@

void BrowserAccessibilityManager::Remove(int32 child_id, int32 renderer_id) {

child_id_map_.erase(child_id);

+ // TODO(ctguil): Investigate if hit. We should never have a newer entry.

+ DCHECK(renderer_id_to_child_id_map_[renderer_id] == child_id);

// Make sure we don't overwrite a newer entry (see UpdateNode for a possible

// corner case).

if (renderer_id_to_child_id_map_[renderer_id] == child_id)