chrome/browser/accessibility/browser_accessibility_manager_unittest.cc - Issue 7648055: Add DCHECK to BrowserAccessibilityManager::Remove to detect undefined behavoir that may lead to a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/accessibility/browser_accessibility_manager_unittest.cc

Issue 7648055: Add DCHECK to BrowserAccessibilityManager::Remove to detect undefined behavoir that may lead to a... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Address unit_tests errors on mac Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/accessibility/browser_accessibility_mac_unittest.mm ('k') | content/browser/accessibility/browser_accessibility_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/accessibility/browser_accessibility_manager_unittest.cc

===================================================================

--- chrome/browser/accessibility/browser_accessibility_manager_unittest.cc (revision 97086)

+++ chrome/browser/accessibility/browser_accessibility_manager_unittest.cc (working copy)

@@ -604,7 +604,7 @@

tree2_1.role = WebAccessibility::ROLE_WEB_AREA;

WebAccessibility tree2_2;

- tree2_2.id = 1001;

+ tree2_2.id = 1002;

tree2_2.role = WebAccessibility::ROLE_BUTTON;

tree2_1.children.push_back(tree2_2);

@@ -614,18 +614,15 @@

// Fire another load complete.

manager->OnAccessibilityNotifications(params);

- BrowserAccessibility* acc2_2 = manager->GetFromRendererID(1001);

+ BrowserAccessibility* acc2_2 = manager->GetFromRendererID(1002);

// Verify the root has not changed.

EXPECT_EQ(root, manager->GetRoot());

- // And the proper child remains.

+ // And the new child exists.

EXPECT_EQ(WebAccessibility::ROLE_BUTTON, acc2_2->role());

- EXPECT_EQ(1001, acc2_2->renderer_id());

+ EXPECT_EQ(1002, acc2_2->renderer_id());

- // Verify we don't reuse objects that have changed roles.

- EXPECT_NE(acc1_2, acc2_2);

// Ensure we properly cleaned up.

manager.reset();

ASSERT_EQ(0, CountedBrowserAccessibility::global_obj_count_);