Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: chrome/test/webdriver/commands/webdriver_command.cc

Issue 7648053: [chromedriver] Add chrome.detach option for configuring Chrome not to quit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win compile issue Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/commands/webdriver_command.h ('k') | chrome/test/webdriver/test/alerts.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/commands/webdriver_command.cc
diff --git a/chrome/test/webdriver/commands/webdriver_command.cc b/chrome/test/webdriver/commands/webdriver_command.cc
index 3220316985ed8488ebddb9058e6bddd03b8e54a4..eed1d11cec0684e7f89c6c8b817e1f38f7f129b9 100644
--- a/chrome/test/webdriver/commands/webdriver_command.cc
+++ b/chrome/test/webdriver/commands/webdriver_command.cc
@@ -50,4 +50,12 @@ bool WebDriverCommand::Init(Response* const response) {
return true;
}
+void WebDriverCommand::Finish() {
+ scoped_ptr<Error> error(session_->AfterExecuteCommand());
+ if (error.get()) {
+ LOG(WARNING) << "Command did not finish successfully: "
+ << error->GetErrorMessage();
+ }
+}
+
} // namespace webdriver
« no previous file with comments | « chrome/test/webdriver/commands/webdriver_command.h ('k') | chrome/test/webdriver/test/alerts.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698