Issue 7648045: Remove the include dependency of the chrome_notification_types.h header from content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7648045: Remove the include dependency of the chrome_notification_types.h header from content. (Closed)

Created:
9 years, 4 months ago by ananta

Modified:
9 years, 4 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove the include dependency of the chrome_notification_types.h header from content. The dependency was in the ResourceDispatcherHostBrowserTest code which subscribed to the chrome::NOTIFICATION_BROWSER_WINDOW_READY event fired by Chrome. To remove this dependency these tests now subscribe to the notification content::NOTIFICATION_TAB_ADDED which is fired after the above notification. Fixes bug http://crbug.com/88871 BUG=88871 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96975

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	content/browser/DEPS	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	content/browser/renderer_host/resource_dispatcher_host_browsertest.cc	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

9 years, 4 months ago (2011-08-16 01:19:31 UTC) #2

lgtm

http://codereview.chromium.org/7648045/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/resource_dispatcher_host_browsertest.cc
(right):

http://codereview.chromium.org/7648045/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/resource_dispatcher_host_browsertest.cc:8:
#include "content/common/content_notification_types.h"
nit: move this down

Expand Messages | Collapse Messages