Issue 7648043: Include chromeos_wm_ipc_enums.h from third_party/cros_system_api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7648043: Include chromeos_wm_ipc_enums.h from third_party/cros_system_api. (Closed)

Created:
9 years, 4 months ago by satorux1

Modified:
9 years, 4 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, derat+watch_chromium.org, rharrison, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr., davemoore+watch_chromium.org, nkostylev+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Include chromeos_wm_ipc_enums.h from third_party/cros_system_api. % grep -l '#include.*chromeos_wm_ipc_enums.h' **/*.{cc,h} > files.txt % perl -i -pe 's!"third_party/cros/chromeos_wm_ipc_enums.h"!"third_party/cros_system_api/window_manager/chromeos_wm_ipc_enums.h"!' `cat files.txt` BUG=chromium-os:19054 TEST=confirm chrome builds as before Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97002

Patch Set 1 #

Patch Set 2 : fix check_deps failure #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -17 lines)			Patch
M	chrome/browser/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/frame/browser_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/frame/layout_mode_button.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/frame/panel_browser_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/frame/panel_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/frame/panel_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/background_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/base_login_display_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/screen_locker.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/user_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/version_info_updater.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/notifications/notification_panel.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/panels/panel_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/system_key_event_listener.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/wm_ipc.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/browser_bubble_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bubble/bubble.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_popup.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages