Add means for running some tests only o-o-p, add messaging o-o-p test.

ppapi/tests/test_post_message.cc

Index: ppapi/tests/test_post_message.cc
diff --git a/ppapi/tests/test_post_message.cc b/ppapi/tests/test_post_message.cc
index 02ebed6bf6fd9893758110a9723a739d6125fb8d..21c3abbf36377e9dde5b7bbd995d938525ed4fbe 100644
--- a/ppapi/tests/test_post_message.cc
+++ b/ppapi/tests/test_post_message.cc
@@ -11,6 +11,7 @@
 #include "ppapi/cpp/dev/scriptable_object_deprecated.h"
 #include "ppapi/cpp/instance.h"
 #include "ppapi/cpp/var.h"
+#include "ppapi/tests/pp_thread.h"
 #include "ppapi/tests/test_utils.h"
 #include "ppapi/tests/testing_instance.h"
 
@@ -28,6 +29,25 @@ const bool kTestBool = true;
 const int32_t kTestInt = 42;
 const double kTestDouble = 42.0;
 const int32_t kThreadsToRun = 10;
+const int32_t kMessagesToSendPerThread = 50;
+
+// The struct that invoke_post_message_thread_func expects for its argument.
+// It includes the instance on which to invoke PostMessage, and the value to
+// pass to PostMessage.
+struct InvokePostMessageThreadArg {
+  InvokePostMessageThreadArg(pp::Instance* i, const pp::Var& v)
+      : instance(i), value_to_send(v) {}
+  pp::Instance* instance;
+  pp::Var value_to_send;
+};
+
+void InvokePostMessageThreadFunc(void* user_data) {
+  InvokePostMessageThreadArg* arg =
+      static_cast<InvokePostMessageThreadArg*>(user_data);
+  for (int32_t i = 0; i < kMessagesToSendPerThread; ++i)
+    arg->instance->PostMessage(arg->value_to_send);
+  delete arg;
+}
 
 }  // namespace
 
@@ -40,6 +60,8 @@ void TestPostMessage::RunTest() {
   RUN_TEST(MessageEvent);
   RUN_TEST(NoHandler);
   RUN_TEST(ExtraParam);
+  if (testing_interface_->IsOutOfProcess())
+    RUN_TEST(NonMainThread);
 }
 
 void TestPostMessage::HandleMessage(const pp::Var& message_data) {
@@ -254,3 +276,66 @@ std::string TestPostMessage::TestExtraParam() {
   PASS();
 }
 
+std::string TestPostMessage::TestNonMainThread() {
+  ASSERT_TRUE(ClearListeners());
+  ASSERT_TRUE(AddEchoingListener("message_event.data"));
+  message_data_.clear();
+
+  // Set up a thread for each integer from 0 to (kThreadsToRun - 1).  Make each
+  // thread send the number that matches its index kMessagesToSendPerThread
+  // times.  For good measure, call postMessage from the main thread
+  // kMessagesToSendPerThread times. At the end, we make sure we got all the
+  // values we expected.
+  PP_ThreadType threads[kThreadsToRun];
+  for (int32_t i = 0; i < kThreadsToRun; ++i) {
+    // Set up a thread to send a value of i.
+    void* arg = new InvokePostMessageThreadArg(instance_, pp::Var(i));
+    PP_CreateThread(&threads[i], &InvokePostMessageThreadFunc, arg);
+  }
+  // Invoke PostMessage right now to send a value of (kThreadsToRun).
+  for (int32_t j = 0; j < kMessagesToSendPerThread; ++j)

[polina, 2011/08/17 17:58:15]

this can be i, no?

[dmichael (off chromium), 2011/08/17 21:15:15]

Done.

+    instance_->PostMessage(pp::Var(kThreadsToRun));
+
+  // Now join all threads.
+  for (int32_t i = 0; i < kThreadsToRun; ++i) {

[polina, 2011/08/17 17:58:15]

don't need {}

[dmichael (off chromium), 2011/08/17 21:15:15]

Done.

+    PP_JoinThread(threads[i]);
+  }
+
+  // PostMessage is asynchronous, so we should not receive a response yet.
+  ASSERT_EQ(message_data_.size(), 0);
+
+  // Make sure we got all values that we expected.  Note that because it's legal
+  // for the JavaScript engine to treat our integers as floating points, we
+  // can't just use std::find or equality comparison. So we first put the

[polina, 2011/08/17 17:58:15]

you should be able to use the equality comparison at least in cases when it is
an int, no?

[dmichael (off chromium), 2011/08/17 21:15:15]

Yes, but that doesn't save me anything, since it may come back as a double, and
I can't use equality in that case. The comment was wrong below, though, so I
updated it.

+  // integer version of all the received Vars in to received_ints, and build up
+  // expected_ints. After the loop, we can sort received_int (they may have
+  // arrived out of order) and compare to the expected_ints.
+  int32_t expected_num = (kThreadsToRun + 1) * kMessagesToSendPerThread;
+  // Count how many we receive per-index.
+  std::vector<int32_t> expected_counts(kThreadsToRun + 1,
+                                     kMessagesToSendPerThread);

[polina, 2011/08/17 17:58:15]

wrong indentation

[dmichael (off chromium), 2011/08/17 21:15:15]

Done.

+  std::vector<int32_t> received_counts(kThreadsToRun + 1, 0);
+  for (int32_t i = 0; i < expected_num; ++i) {
+    // Run the message loop to get the next expected message.
+    testing_interface_->RunMessageLoop(instance_->pp_instance());
+    // Make sure we got another message in.
+    ASSERT_EQ(message_data_.size(), 1);
+    pp::Var latest_var(message_data_.back());
+    message_data_.clear();
+
+    ASSERT_TRUE(latest_var.is_int() || (latest_var.is_double()));
+    int32_t received_value = -1;
+    if (latest_var.is_int()) {
+      received_value = latest_var.AsInt();
+    } else if (latest_var.is_double()) {
+      received_value = static_cast<int32_t>(latest_var.AsDouble() + 0.5);
+    }
+    ASSERT_TRUE(received_value >= 0);
+    ASSERT_TRUE(received_value <= kThreadsToRun);
+    ++received_counts[received_value];
+  }
+  ASSERT_EQ(received_counts, expected_counts);
+
+  PASS();
+}
+