DevTools: introduce DevToolsAgentHost

DevTools: introduce DevToolsAgentHost

We need an abstract interface that would encapsulate communication
with inspected instance DeviTools agent. It'is going to have different
implementations at least for render views and shared workers. This
patch leaves all methods on the DevToolsManager that accept inspected
RenderViewHost just for convenience. Eventually DevToolsManager should
operate in terms of DevToolsAgentHost and DevToolsClientHost only.


BUG=None
TEST=DevTools tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96906

[pfeldman, 2011-08-16 06:48:57]

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/devtoo...
File content/browser/debugger/devtools_agent_host.h (right):

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/devtoo...
content/browser/debugger/devtools_agent_host.h:24: int routing_id() const {
return routing_id_; }
Could you assign routing id within agent host implementation instead?

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/devtoo...
content/browser/debugger/devtools_agent_host.h:32: };
DISALLOW_COPY_AND_ASSIGN ?

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/devtoo...
File content/browser/debugger/devtools_manager.h (right):

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/devtoo...
content/browser/debugger/devtools_manager.h:39: DevToolsClientHost*
GetDevToolsClientHostFor(RenderViewHost* inspected_rvh);
Could you group rvh methods and comment on the block that those are convenience
methods for rvh processing?

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/devtoo...
content/browser/debugger/devtools_manager.h:95: void
BindClientHost(RenderViewHost* inspected_rvh,
Bind and Unbind should operate similar terms. Could you make Bind accept
agent_host?

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/render...
File content/browser/debugger/render_view_devtools_agent_host.cc (right):

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/render...
content/browser/debugger/render_view_devtools_agent_host.cc:63:
DevToolsManager::GetInstance()->UnregisterDevToolsClientHostFor(this);
I'd copy the DevToolsClientHost's NotifyCloseListener.

[yurys, 2011-08-16 08:14:47]

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/devtoo...
File content/browser/debugger/devtools_agent_host.h (right):

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/devtoo...
content/browser/debugger/devtools_agent_host.h:24: int routing_id() const {
return routing_id_; }
On 2011/08/16 06:48:57, pfeldman wrote:
> Could you assign routing id within agent host implementation instead?

Done.

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/devtoo...
content/browser/debugger/devtools_agent_host.h:32: };
On 2011/08/16 06:48:57, pfeldman wrote:
> DISALLOW_COPY_AND_ASSIGN ?

The class is abstract, no need to put the declaration here.

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/devtoo...
File content/browser/debugger/devtools_manager.h (right):

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/devtoo...
content/browser/debugger/devtools_manager.h:39: DevToolsClientHost*
GetDevToolsClientHostFor(RenderViewHost* inspected_rvh);
On 2011/08/16 06:48:57, pfeldman wrote:
> Could you group rvh methods and comment on the block that those are
convenience
> methods for rvh processing?

Done.

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/devtoo...
content/browser/debugger/devtools_manager.h:95: void
BindClientHost(RenderViewHost* inspected_rvh,
On 2011/08/16 06:48:57, pfeldman wrote:
> Bind and Unbind should operate similar terms. Could you make Bind accept
> agent_host?

Done.

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/render...
File content/browser/debugger/render_view_devtools_agent_host.cc (right):

http://codereview.chromium.org/7648032/diff/1/content/browser/debugger/render...
content/browser/debugger/render_view_devtools_agent_host.cc:63:
DevToolsManager::GetInstance()->UnregisterDevToolsClientHostFor(this);
On 2011/08/16 06:48:57, pfeldman wrote:
> I'd copy the DevToolsClientHost's NotifyCloseListener.

Done.

[pfeldman, 2011-08-16 08:50:01]

LGTM