More distinguishable message is spoken when accessibility is enabled/disabled on login screen.

More distinguishable message is spoken when accessibility is enabled/disabled on login screen.

BUG=chromium-os:11950
TEST=Press Ctrl+Alt+Z on login screen and listen to what is spoken.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96902

[hashimoto, 2011-08-15 09:55:55]

Could you review this?

Since I am not a native English speaker, please suggest me other expressions if
you have any better ideas.

[dmazzoni, 2011-08-16 04:52:47]

LGTM

I like switching to "enabling" and "disabling", but since you're going to be
working on magnification support soon, I think it'd be even better to stop using
the generic word "accessibility" and be more specific. So I suggest:

* Enabling spoken feedback
and
* Disabling spoken feedback

I ran this by a few other accessibility team people and they like it. Sound
good?

Then we should make a similar change to the Accessibility checkbox in the
settings - we should have a category for Accessibility, and separate checkboxes
for Spoken feedback, Magnification, and later maybe other options like
high-contrast.

[hashimoto, 2011-08-16 07:04:37]

Thank you for your kind suggestion, now the message looks more distinguishable
and meaningful.
I will commit this new patch.

About the word "accessibility", I agree with you that the word is too ambiguous
and words like "spoken feedback" and "magnification" are better choices.
Beside making a category in the settings, is there a plan to replace the word
"accessibility" in the entire chrome source tree with other more precise words?
Should I avoid using the ambiguous word "accessibility" in new codes?


On 2011/08/16 04:52:47, Dominic Mazzoni wrote:
> LGTM
> 
> I like switching to "enabling" and "disabling", but since you're going to be
> working on magnification support soon, I think it'd be even better to stop
using
> the generic word "accessibility" and be more specific. So I suggest:
> 
> * Enabling spoken feedback
> and
> * Disabling spoken feedback
> 
> I ran this by a few other accessibility team people and they like it. Sound
> good?
> 
> Then we should make a similar change to the Accessibility checkbox in the
> settings - we should have a category for Accessibility, and separate
checkboxes
> for Spoken feedback, Magnification, and later maybe other options like
> high-contrast.

[dmazzoni, 2011-08-16 15:05:00]

On Tue, Aug 16, 2011 at 12:04 AM, <hashimoto@chromium.org> wrote:

> Thank you for your kind suggestion, now the message looks more
> distinguishable
> and meaningful.
> I will commit this new patch.
>
> About the word "accessibility", I agree with you that the word is too
> ambiguous
> and words like "spoken feedback" and "magnification" are better choices.
> Beside making a category in the settings, is there a plan to replace the
> word
> "accessibility" in the entire chrome source tree with other more precise
> words?
> Should I avoid using the ambiguous word "accessibility" in new codes?


I think we should still use the word Accessibility, because that's the right
general term used in software development to indicate special functionality
provided for people who might not use the standard user interface in any
way. However, we should try to be more specific when possible - instead of
EnableAccessibility, it'd be better to have a method like
EnableChromeVoxForAccessibility or EnableAccessibleSpokenFeedback.

- Dominic