Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 7648026: MIPS: port Simplify handling of exits from with and catch. (Closed)

Created:
9 years, 4 months ago by Paul Lind
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: port Simplify handling of exits from with and catch. Ported r8922 (5ea2fb5) Original commit message: Remove the try/finally used for with and catch. Instead of using try/finally to handle break and continue from with or catch, statically track nesting dept and clean up when compiling break or continue. And instead of using try/finally to handle throw to handler in a frame whose pc is inside a with or catch, store the context that the handler should run in in the handler itself. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8936

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -51 lines) Patch
M src/mips/frames-mips.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 11 chunks +45 lines, -47 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Paul Lind
9 years, 4 months ago (2011-08-15 05:36:58 UTC) #1
Kevin Millikin (Chromium)
9 years, 4 months ago (2011-08-16 08:42:14 UTC) #2
LGTM.  I will land it.

http://codereview.chromium.org/7648026/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):

http://codereview.chromium.org/7648026/diff/1/src/mips/macro-assembler-mips.c...
src/mips/macro-assembler-mips.cc:2281: li(t0, Operand(StackHandler::ENTRY));
StackHandler::ENTRY is zero.  If you wanted to rely on that (with a static
assert), you could avoid the load here.

Powered by Google App Engine
This is Rietveld 408576698