Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4432)

Unified Diff: chrome/renderer/extensions/chrome_app_bindings.cc

Issue 7648023: renderer/extensions: Return v8::False() where possible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/chrome_app_bindings.cc
diff --git a/chrome/renderer/extensions/chrome_app_bindings.cc b/chrome/renderer/extensions/chrome_app_bindings.cc
index b85b6171ce92616ffd36e4f016f1566b1f1d71bc..4af5e581c048926e3cea8dd01538e0c444ba831b 100644
--- a/chrome/renderer/extensions/chrome_app_bindings.cc
+++ b/chrome/renderer/extensions/chrome_app_bindings.cc
@@ -102,13 +102,13 @@ class ChromeAppExtensionWrapper : public v8::Extension {
static v8::Handle<v8::Value> GetIsInstalled(const v8::Arguments& args) {
WebFrame* frame = WebFrame::frameForCurrentContext();
if (!frame)
- return v8::Boolean::New(false);
+ return v8::False();
GURL url(frame->document().url());
if (url.is_empty() ||
!url.is_valid() ||
!(url.SchemeIs("http") || url.SchemeIs("https")))
- return v8::Boolean::New(false);
+ return v8::False();
const ::Extension* extension =
extension_dispatcher_->extensions()->GetByURL(frame->document().url());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698