Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 7648022: Added kAPPhoneMobileLabel and kABPhoneMainLabel in GetAddressBookPhoneNumbers. (Closed)

Created:
9 years, 4 months ago by honten
Modified:
9 years, 4 months ago
CC:
chromium-reviews, GeorgeY, Ilya Sherman, dhollowa
Visibility:
Public.

Description

Added kAPPhoneMobileLabel and kABPhoneMainLabel in GetAddressBookPhoneNumbers. To fill work and mobile phone numbers, added two const condisions BUG=64868 TEST=1. Create an Address Book me card that has a work address and a mobile number 2. Navigate to an autofillable form. 3. Try to fill the form. 4. The phone number field is filled with the AB's mobile number. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/autofill/personal_data_manager_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
honten
Please review.
9 years, 4 months ago (2011-08-14 21:39:17 UTC) #1
dhollowa
LGTM. Thanks!
9 years, 4 months ago (2011-08-15 16:36:29 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-15 18:12:40 UTC) #3
Change committed as 96795

Powered by Google App Engine
This is Rietveld 408576698