Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7648017: Make WebPluginInfo more generic (Closed)

Created:
9 years, 4 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, kkania, Erik does not do reviews, brettw-cc_chromium.org, jam, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, pam+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Make WebPluginInfo more generic - To account for pepper plugins, it grows a type field - move WebPluginInfo from webkit::npapi to webkit:: and move the files as well. This will allow us to remove hacks to get pepper plugins to load soon BUG=89248 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96718

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 5

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -430 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_content_settings_apitest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_log.h View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/pdf_unsupported_feature.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/plugin_data_remover.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_data_remover.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/plugin_exceptions_table_model.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/plugin_exceptions_table_model_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/plugin_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugin_updater.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/plugin_updater.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/drag_util.mm View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 2 3 4 chunks +15 lines, -15 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/plugin_process_host.h View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/plugin_service.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/plugin_service_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/buffered_resource_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M content/common/pepper_plugin_registry.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/pepper_plugin_registry.cc View 1 4 chunks +8 lines, -9 lines 0 comments Download
M content/common/view_messages.h View 6 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/render_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/renderer_glue.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/proxy_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkit_glue.h View 2 chunks +1 line, -3 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/npapi/plugin_group.h View 9 chunks +17 lines, -15 lines 0 comments Download
M webkit/plugins/npapi/plugin_group.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_group_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_lib.h View 5 chunks +7 lines, -7 lines 0 comments Download
M webkit/plugins/npapi/plugin_lib.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_list.h View 11 chunks +20 lines, -17 lines 0 comments Download
M webkit/plugins/npapi/plugin_list.cc View 19 chunks +24 lines, -23 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_win.cc View 4 chunks +6 lines, -6 lines 0 comments Download
D webkit/plugins/npapi/webplugininfo.h View 1 chunk +0 lines, -106 lines 0 comments Download
D webkit/plugins/npapi/webplugininfo.cc View 1 chunk +0 lines, -69 lines 0 comments Download
A + webkit/plugins/webplugininfo.h View 5 chunks +13 lines, -8 lines 0 comments Download
A + webkit/plugins/webplugininfo.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M webkit/support/webkit_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/support/webkit_support_glue.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
LGTM http://codereview.chromium.org/7648017/diff/7063/chrome/common/chrome_content_client.cc File chrome/common/chrome_content_client.cc (right): http://codereview.chromium.org/7648017/diff/7063/chrome/common/chrome_content_client.cc#newcode274 chrome/common/chrome_content_client.cc:274: ::OutputDebugStringA("ChromeContentClient::AddPepperPlugins"); remove http://codereview.chromium.org/7648017/diff/7063/webkit/plugins/npapi/plugin_group.h File webkit/plugins/npapi/plugin_group.h (right): http://codereview.chromium.org/7648017/diff/7063/webkit/plugins/npapi/plugin_group.h#newcode119 webkit/plugins/npapi/plugin_group.h:119: ...
9 years, 4 months ago (2011-08-14 02:46:06 UTC) #1
cpu_(ooo_6.6-7.5)
9 years, 4 months ago (2011-08-17 02:28:33 UTC) #2 
forgot to hit send. please ignore anyway.

http://codereview.chromium.org/7648017/diff/7063/webkit/plugins/npapi/plugin_...
File webkit/plugins/npapi/plugin_group.h (right):

http://codereview.chromium.org/7648017/diff/7063/webkit/plugins/npapi/plugin_...
webkit/plugins/npapi/plugin_group.h:119: bool Match(const webkit::WebPluginInfo&
plugin) const;
Felt more consistent. In some places it seems to matter but I am too drowsy with
this mindless change.

On 2011/08/14 02:46:06, Nico wrote:
> Do you need the namespace qualification here? Both gcc and clang seem to be
> happy without it.

http://codereview.chromium.org/7648017/diff/7063/webkit/plugins/webplugininfo.h
File webkit/plugins/webplugininfo.h (right):

http://codereview.chromium.org/7648017/diff/7063/webkit/plugins/webplugininfo...
webkit/plugins/webplugininfo.h:103: int type;
And the nacl type might force us into a fake bitfield like the enabledstates.

On 2011/08/14 02:46:06, Nico wrote:
> Why not PluginType?
> 
> …nvm, because of the IPC macros I suppose

Powered by Google App Engine
This is Rietveld 408576698