Issue 7648013: Whitespace to force Mac Clobber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7648013: Whitespace to force Mac Clobber (Closed)

Created:
9 years, 4 months ago by Ryan Sleevi

Modified:
9 years, 4 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Whitespace to force Mac Clobber BUG=none TEST=none TBR=thakis Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96705

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/whitespace_file.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

9 years, 4 months ago (2011-08-13 19:44:31 UTC) #2

LGTM

On Sat, Aug 13, 2011 at 12:41 PM,  <rsleevi@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Whitespace to force Mac Clobber
>
> BUG=none
> TEST=none
> TBR=thakis
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96705
>
> Please review this at http://codereview.chromium.org/7648013/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M build/whitespace_file.txt
>
>
> Index: build/whitespace_file.txt
> diff --git a/build/whitespace_file.txt b/build/whitespace_file.txt
> index
>
59b7c3103d20bb41ad692fd093fccdfadcfada1b..5e514e36a350c551634f1f0f1c54cb41e942de3b
> 100644
> --- a/build/whitespace_file.txt
> +++ b/build/whitespace_file.txt
> @@ -16,5 +16,5 @@ the housetops, and fiercely agitating the scanty flame of
> the lamps that
>  struggled against the darkness. A dark figure emerged.
>
>  It was a Domo-Kun. "What took you so long?", inquired his wife.
> -Silence.
> +Silence. Not noticing his silence, she continued, "Did Mr. Usagi enjoy the
> waffles you brought him?"
>
>
>
>

Expand Messages | Collapse Messages