Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 7648001: Enable the packed_resources target on Windows. (Closed)

Created:
9 years, 4 months ago by tony
Modified:
9 years, 4 months ago
CC:
chromium-reviews, finnur+watch_chromium.org, pam+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Enable the packed_resources target on Windows. This target generates the locale .pak files on Windows. Since nothing depends on this target, it doesn't build by default (they're not used yet). Specific changes: - Have locale_settings_win.grd generate .pak files. - Use pymod_do_main to avoid some shell escaping problems (and it's a bit faster). - Rewrite repack_locales.py to work with pymod_do_main. BUG=92724 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97012

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -76 lines) Patch
M build/gyp_chromium View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/app/resources/locale_settings_win.grd View 1 chunk +56 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 4 chunks +5 lines, -10 lines 2 comments Download
M chrome/tools/build/repack_locales.py View 7 chunks +60 lines, -65 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tony
thakis: pymod_do_main related changes. mmoss: repack_locales.py changes.
9 years, 4 months ago (2011-08-12 21:38:41 UTC) #1
Nico
LGTM http://codereview.chromium.org/7648001/diff/1/chrome/chrome.gyp File chrome/chrome.gyp (right): http://codereview.chromium.org/7648001/diff/1/chrome/chrome.gyp#newcode1682 chrome/chrome.gyp:1682: '<!@pymod_do_main(repack_locales -o -g <(grit_out_dir) -s <(SHARED_INTERMEDIATE_DIR) -x <(INTERMEDIATE_DIR) ...
9 years, 4 months ago (2011-08-12 21:46:25 UTC) #2
tony
http://codereview.chromium.org/7648001/diff/1/chrome/chrome.gyp File chrome/chrome.gyp (right): http://codereview.chromium.org/7648001/diff/1/chrome/chrome.gyp#newcode1682 chrome/chrome.gyp:1682: '<!@pymod_do_main(repack_locales -o -g <(grit_out_dir) -s <(SHARED_INTERMEDIATE_DIR) -x <(INTERMEDIATE_DIR) <(locales))' ...
9 years, 4 months ago (2011-08-12 21:53:36 UTC) #3
Michael Moss
LGTM
9 years, 4 months ago (2011-08-12 22:10:27 UTC) #4
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 4 months ago (2011-08-15 23:44:36 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-08-16 20:43:29 UTC) #6
Change committed as 97012

Powered by Google App Engine
This is Rietveld 408576698