Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: webkit/glue/webcursor_mac.mm

Issue 7647030: Add link to SPIs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: space Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webcursor_mac.mm
diff --git a/webkit/glue/webcursor_mac.mm b/webkit/glue/webcursor_mac.mm
index 34f3592c2d36008ed7d12df6c7cf6f93c74edc2f..c00f57cab01bd1590a5cf446ecb7ca91fd5e1a06 100644
--- a/webkit/glue/webcursor_mac.mm
+++ b/webkit/glue/webcursor_mac.mm
@@ -111,7 +111,13 @@ NSCursor* CreateCustomCursor(const std::vector<char>& custom_data,
} // namespace
-// We're matching Safari's cursor choices; see platform/mac/CursorMac.mm
+// We're (mostly) matching Safari's cursor choices; see
+// platform/mac/CursorMac.mm . Note that Safari uses some magic in wkCursor to
+// access private system cursors. A sample implementation using the same
+// technique can be found attached to http://crbug.com/92892 . However, it's not
+// clear that accessing system cursors this way is enough of a gain to risk
+// using SPIs. Until the benefits more clearly outweigh the risks, API is all
+// that will be used.
NSCursor* WebCursor::GetCursor() const {
switch (type_) {
case WebCursorInfo::TypePointer:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698