Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: printing/cups_config_helper.py

Issue 7647025: cups-helper: split on newlines in cups helper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """cups-config wrapper. 6 """cups-config wrapper.
7 7
8 cups-config, at least on Ubuntu Lucid and Natty, dumps all 8 cups-config, at least on Ubuntu Lucid and Natty, dumps all
9 cflags/ldflags/libs when passed the --libs argument. gyp would like 9 cflags/ldflags/libs when passed the --libs argument. gyp would like
10 to keep these separate: cflags are only needed when compiling files 10 to keep these separate: cflags are only needed when compiling files
(...skipping 14 matching lines...) Expand all
25 25
26 def run_cups_config(mode): 26 def run_cups_config(mode):
27 """Run cups-config with all --cflags etc modes, parse out the mode we want, 27 """Run cups-config with all --cflags etc modes, parse out the mode we want,
28 and return those flags as a list.""" 28 and return those flags as a list."""
29 29
30 cups = subprocess.Popen(['cups-config', '--cflags', '--ldflags', '--libs'], 30 cups = subprocess.Popen(['cups-config', '--cflags', '--ldflags', '--libs'],
31 stdout=subprocess.PIPE) 31 stdout=subprocess.PIPE)
32 flags = cups.communicate()[0].strip() 32 flags = cups.communicate()[0].strip()
33 33
34 flags_subset = [] 34 flags_subset = []
35 for flag in flags.split(' '): 35 for flag in flags.split():
36 flag_mode = None 36 flag_mode = None
37 if flag.startswith('-l'): 37 if flag.startswith('-l'):
38 flag_mode = '--libs' 38 flag_mode = '--libs'
39 elif (flag.startswith('-L') or flag.startswith('-Wl,')): 39 elif (flag.startswith('-L') or flag.startswith('-Wl,')):
40 flag_mode = '--ldflags' 40 flag_mode = '--ldflags'
41 elif (flag.startswith('-I') or flag.startswith('-D')): 41 elif (flag.startswith('-I') or flag.startswith('-D')):
42 flag_mode = '--cflags' 42 flag_mode = '--cflags'
43 43
44 # Be conservative: for flags where we don't know which mode they 44 # Be conservative: for flags where we don't know which mode they
45 # belong in, always include them. 45 # belong in, always include them.
46 if flag_mode is None or flag_mode == mode: 46 if flag_mode is None or flag_mode == mode:
47 flags_subset.append(flag) 47 flags_subset.append(flag)
48 48
49 return flags_subset 49 return flags_subset
50 50
51 if len(sys.argv) != 2: 51 if len(sys.argv) != 2:
52 usage() 52 usage()
53 53
54 mode = sys.argv[1] 54 mode = sys.argv[1]
55 if mode not in ('--cflags', '--libs', '--ldflags'): 55 if mode not in ('--cflags', '--libs', '--ldflags'):
56 usage() 56 usage()
57 flags = run_cups_config(mode) 57 flags = run_cups_config(mode)
58 print ' '.join(flags) 58 print ' '.join(flags)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698