ntp4: Horizontal swipes should only trigger history on mac when

ntp4: Horizontal swipes should only trigger history on mac when
the ntp is at the first card (for backward navigation) or last
card (for forward navigation).

BUG=92786, 92785
TEST=see bug


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97566

[Nico, 2011-08-15 04:15:08]

Also see http://codereview.chromium.org/7618036/

[Evan Stade, 2011-08-15 21:45:14]

I think it would work better if you prevent default any time this != rightmost
(or leftmost in the other case)

[Nico, 2011-08-15 22:05:49]

On Mon, Aug 15, 2011 at 2:45 PM,  <estade@chromium.org> wrote:
> I think it would work better if you prevent default any time this !=
> rightmost
> (or leftmost in the other case)

Isn't that what this patch is doing?

[Evan Stade, 2011-08-15 22:21:28]

the difference is the behavior if you are already on the rightmost page and
start horizontal scrolling (but move your fingers less than scrollAmountPerPage)

hard to make a judgment call on what's best for the above case without having a
mac in front of me to play with, so it's up to you.

[Evan Stade, 2011-08-15 22:29:16]

by the way, the value of scrollAmountPerPage was not picked to
optimize the mac touchpad experience, but the experience with my
particular mouse scrollwheel (which has a horizontal scroll flicker).
The weird contortions the code goes through are a result of the
different event pattern for a scroll wheel (which is a discreet input
device) and a touchpad (which doesn't seem discreet to the user; we
get a lot more events with smaller values). Also some things are lost
in translation to the scroll event type: AFAIK we don't get any event
for important things like "user released touchpad", which is why we
have to do this timer thing. Bottom line, you might want to tweak the
scrollAmountPerPage value for mac.

-- Evan Stade



On Mon, Aug 15, 2011 at 3:21 PM,  <estade@chromium.org> wrote:
> the difference is the behavior if you are already on the rightmost page and
> start horizontal scrolling (but move your fingers less than
> scrollAmountPerPage)
>
> hard to make a judgment call on what's best for the above case without
> having a
> mac in front of me to play with, so it's up to you.
>
> http://codereview.chromium.org/7647015/
>

[Nico, 2011-08-19 22:22:46]

Made the threshold slightly higher, made the logic work with that threshold.
(Your suggestion as I understood it didn't work, because that way you could
trigger backward navigation on the 3rd ntp pane, which felt wrong).

Sorry it took so long to get back to this.

[Evan Stade, 2011-08-19 22:35:40]

lgtm

you can also add bug 92785

http://codereview.chromium.org/7647015/diff/6001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/card_slider.js (right):

http://codereview.chromium.org/7647015/diff/6001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/card_slider.js:230: this.mouseWheelScrollAmount_ <
0)
curlies

http://codereview.chromium.org/7647015/diff/6001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/card_slider.js:233: var scrollAmountPerPage =
cr.isMac ? 400 : 120;
it strikes me you should test this with a mouse with a scroll wheel (on mac), if
you have one handy. I assume you just tried it with a touchpad. Shift+scroll
does horizontal, at least for me, although my wheel also has left and right
clickers.

[Nico, 2011-08-19 22:54:47]

Thanks!

http://codereview.chromium.org/7647015/diff/6001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/card_slider.js (right):

http://codereview.chromium.org/7647015/diff/6001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/card_slider.js:230: this.mouseWheelScrollAmount_ <
0)
On 2011/08/19 22:35:40, Evan Stade wrote:
> curlies

Done.

http://codereview.chromium.org/7647015/diff/6001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/card_slider.js:233: var scrollAmountPerPage =
cr.isMac ? 400 : 120;
On 2011/08/19 22:35:40, Evan Stade wrote:
> it strikes me you should test this with a mouse with a scroll wheel (on mac),
if
> you have one handy. I assume you just tried it with a touchpad. Shift+scroll
> does horizontal, at least for me, although my wheel also has left and right
> clickers.

I tested with a multitouch touch pad (feels good), a magic mouse with a physical
scroll ball (feels good) and a logitech mouse with shift-scrolling (I believe
120 would feel better for that, but it's bearable). I added a comment for this.

[Evan Stade, 2011-08-19 23:10:56]

http://codereview.chromium.org/7647015/diff/6001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/card_slider.js (right):

http://codereview.chromium.org/7647015/diff/6001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/card_slider.js:233: var scrollAmountPerPage =
cr.isMac ? 400 : 120;
On 2011/08/19 22:54:47, Nico wrote:
> On 2011/08/19 22:35:40, Evan Stade wrote:
> > it strikes me you should test this with a mouse with a scroll wheel (on
mac),
> if
> > you have one handy. I assume you just tried it with a touchpad. Shift+scroll
> > does horizontal, at least for me, although my wheel also has left and right
> > clickers.
> 
> I tested with a multitouch touch pad (feels good), a magic mouse with a
physical
> scroll ball (feels good) and a logitech mouse with shift-scrolling (I believe
> 120 would feel better for that, but it's bearable). I added a comment for
this.

you could do something hacky like "if the scroll value is exactly 120 then move
the page by 1".

[commit-bot: I haz the power, 2011-08-20 06:18:39]

Change committed as 97566