Print preview page selection should not require a rerendering of draft pages.

chrome/renderer/mock_printer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/mock_printer.h"
 
 #include "base/file_util.h"
 #include "base/shared_memory.h"
 #include "chrome/common/print_messages.h"
 #include "ipc/ipc_message_utils.h"
@@ skipping 80 matching lines @@
   settings->params.selection_only = selection_only_;
   settings->params.document_cookie = document_cookie_;
   settings->params.page_size = page_size_;
   settings->params.printable_size = printable_size_;
   settings->params.is_first_request = is_first_request_;
   settings->params.preview_request_id = preview_request_id_;
   printer_status_ = PRINTER_PRINTING;
 }
 
 void MockPrinter::UpdateSettings(int cookie,
-                                 PrintMsg_PrintPages_Params* params) {
+                                 PrintMsg_PrintPages_Params* params,
+                                 const std::vector<int>& pages) {
   EXPECT_EQ(document_cookie_, cookie);
 
   memset(params, 0, sizeof(PrintMsg_PrintPages_Params));

[Chris Guillory, 2011/08/16 20:08:53]

Looking at this further I think line is your issue. You are using memset to
clear a std::vector isn't valid (especially if the vector has data). If you
remove this it looks like the problem goes away.

[kmadhusu, 2011/08/16 20:53:21]

hmm.. interesting.. I tested without the memset line it is fine. I think Aayush
has a fix to replace the memset. Let me update the CL once he lands his CL.
Thanks for your help Chris. 

+  // On Release version, MSVS crashes the application if we try to assign an
+  // empty vector to an empty vector. Always check for empty vector before
+  // assigning it to another vector.
+  if (pages.size() != 0)
+    params->pages = pages;
+
   SetPrintParams(&(params->params));
   printer_status_ = PRINTER_PRINTING;
 }
 
 void MockPrinter::SetPrintedPagesCount(int cookie, int number_pages) {
   // Verify the input parameter and update the printer status so that the
   // RenderViewTest class can verify the this function finishes without errors.
   EXPECT_EQ(document_cookie_, cookie);
   EXPECT_EQ(PRINTER_PRINTING, printer_status_);
   EXPECT_EQ(0, number_pages_);
@@ skipping 115 matching lines @@
   params->desired_dpi = desired_dpi_;
   params->selection_only = selection_only_;
   params->document_cookie = document_cookie_;
   params->page_size = page_size_;
   params->printable_size = printable_size_;
   params->margin_left = margin_left_;
   params->margin_top = margin_top_;
   params->is_first_request = is_first_request_;
   params->preview_request_id = preview_request_id_;
 }