[Mac] Implement the avatar menu bubble.

[Mac] Implement the avatar menu bubble.

This also makes a change to AvatarMenuModel such that it no longer notifies its
delegate that the model changed at time of construction. It will now only notify
after any other change occurs. This requires clients to now schedule a layout
themselves after constructing the model.

BUG=60105
TEST=Run with --multi-profiles. Click on avatar. See bubble menu.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96851

[Robert Sesek, 2011-08-12 22:55:54]

I always forget the screenshots. I even take them -- just forget to attach them.
http://cl.ly/203S2204043W0e402o00

[sail, 2011-08-13 00:02:39]

LGTM!

Some layout issues:
  - Bottom of the New user link should be 12 pixels from the bottom of the
window, currently it's 6 pixels from the bottom.
  - Space between the New user link and the profile item above it should be
large. Currently it's about 6 pixels. I think it should be about 14 pixels at
least.
  - The margin between the top of the bubble view and the first profile item
seems too smal. Currently it looks like 6 pixels. It should probably be 10
pixels.

Also, the color for profile names should depend on the item's active state and
the mouse hover state. See:
http://google.com/codesearch#wZuuyuB8jKQ/chromium/src/chrome/browser/ui/views...
This can be done later too.

http://codereview.chromium.org/7647002/diff/2001/chrome/browser/ui/cocoa/brow...
File chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm (right):

http://codereview.chromium.org/7647002/diff/2001/chrome/browser/ui/cocoa/brow...
chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm:177: [newButton
setFont:[NSFont labelFontOfSize:12.0]];
can you also change the font color to match the color in the views
implementation

[Robert Sesek, 2011-08-15 20:17:21]

All changes addressed. Even added a unit test.

http://codereview.chromium.org/7647002/diff/2001/chrome/browser/ui/cocoa/brow...
File chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm (right):

http://codereview.chromium.org/7647002/diff/2001/chrome/browser/ui/cocoa/brow...
chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm:177: [newButton
setFont:[NSFont labelFontOfSize:12.0]];
On 2011/08/13 00:02:39, sail wrote:
> can you also change the font color to match the color in the views
> implementation

We should stay consistent. It should either be changed for all our hyperlink
buttons, or they should stay as they are. That color is very Window-y, too.

[Robert Sesek, 2011-08-15 20:20:55]

Screen shot (do'h): http://cl.ly/0E3o3f2G2l022i1f2j19

"Alpha" is in hover state; "Default" is active.

[sail, 2011-08-15 21:10:27]

LGTM
The test looks awesome.