Issue 7647001: ntp4: attribution tweak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7647001: ntp4: attribution tweak (Closed)

Created:
9 years, 4 months ago by Evan Stade

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Rick Byers, alcor

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ntp4: attribution tweak fix the attribution for RTL (put it on the left). Also, flip the attribution side for LTR if the theme is right-aligned. Most right-aligned images will conflict with the theme attribution if it's on the right (it was on the left in ntp3). This fixes the attribution for my personal favorite theme, Justin Bieber, and also Nik Daum, which is OK I guess. I didn't flip for left-aligned themes in RTL because almost all themes are left-aligned, and it's usually not conflicting. BUG=none TEST=install Nik Daum theme; attribution should be legible Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96683

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -5 lines)			Patch
M	chrome/browser/resources/ntp4/new_tab.css	View	1 chunk	+15 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.html	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Change committed as 96683

Expand Messages | Collapse Messages