Character encoding override

Make the character encoding override work again. There are two other bugs with character encoding override, but it seems that it's better to fix them separately.

BUG=3315
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3759

[brettw, 2008-10-20 18:44:33]

http://codereview.chromium.org/7647/diff/202/203
File chrome/browser/browser_commands.cc (right):

http://codereview.chromium.org/7647/diff/202/203#newcode634
Line 634: if (!selected_encoding.empty() && current_tab &&
current_tab->AsWebContents()) {
80 cols.

http://codereview.chromium.org/7647/diff/202/203#newcode635
Line 635: current_tab->set_encoding(selected_encoding);
It doesn't look like set_encoding is called anywhere other than this. I think
this should be moved back to a function on WebContents that will save the
encoding and then forward the message to the R.V.H. I think I probably made this
function and maybe didn't know how this worked.

[jungshik at Google, 2008-10-22 19:53:15]

A new patch is up. Can you take a look? 

On 2008/10/20 18:44:33, brettw wrote:
> http://codereview.chromium.org/7647/diff/202/203
> File chrome/browser/browser_commands.cc (right):
> 
> http://codereview.chromium.org/7647/diff/202/203#newcode634
> Line 634: if (!selected_encoding.empty() && current_tab &&
> current_tab->AsWebContents()) {
> 80 cols.

Ooops. DOne. 
> 
> http://codereview.chromium.org/7647/diff/202/203#newcode635
> Line 635: current_tab->set_encoding(selected_encoding);
> It doesn't look like set_encoding is called anywhere other than this. I think
> this should be moved back to a function on WebContents that will save the
> encoding and then forward the message to the R.V.H. I think I probably made
this
> function and maybe didn't know how this worked.

Done.

[brettw, 2008-10-22 20:03:44]

LGTM