Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 7646032: base: Add DCHECK that double Values are finite. (Closed)

Created:
9 years, 4 months ago by Daniel Erat
Modified:
9 years, 4 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

base: Add DCHECK that double Values are finite. JSON doesn't support NaN or positive/negative infinity. I'm hoping that this DCHECK will slightly increase the odds that bugs are caught before they start corrupting pref files. BUG=73856 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97111

Patch Set 1 #

Patch Set 2 : s/cmath/math.h/ #

Patch Set 3 : switch to IsFinite() from float_util.h #

Patch Set 4 : merge; unrelated libcros failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/values.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Daniel Erat
9 years, 4 months ago (2011-08-15 23:05:42 UTC) #1
tony
LGTM
9 years, 4 months ago (2011-08-15 23:11:22 UTC) #2
commit-bot: I haz the power
Presubmit check for 7646032-6001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 4 months ago (2011-08-17 00:45:40 UTC) #3
Daniel Erat
Evan, mind giving base/ owner blessing?
9 years, 4 months ago (2011-08-17 01:07:30 UTC) #4
Evan Martin
note that dcheck does nothing in release builds LGTM otherwise
9 years, 4 months ago (2011-08-17 01:22:42 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-08-17 08:03:48 UTC) #6
Change committed as 97111

Powered by Google App Engine
This is Rietveld 408576698