Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 7646031: GPU process terminates rather than crashing on hang. (Closed)

Created:
9 years, 4 months ago by apatrick_chromium
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam
Visibility:
Public.

Description

GPU process terminates rather than crashing on hang. Hangs are reported via exit code. BUG=74564, 90406, 74588 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97359

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M content/gpu/gpu_watchdog_thread.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 1 2 5 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
apatrick_chromium
9 years, 4 months ago (2011-08-16 19:58:31 UTC) #1
vangelis
Could we add a histogram entry to keep track of how often the watchdog terminates ...
9 years, 4 months ago (2011-08-16 20:22:56 UTC) #2
apatrick_chromium
I could do it this way. The trouble with having detected a hang is it's ...
9 years, 4 months ago (2011-08-16 21:31:18 UTC) #3
vangelis
On 2011/08/16 21:31:18, apatrick_chromium wrote: > I could do it this way. The trouble with ...
9 years, 4 months ago (2011-08-17 00:09:52 UTC) #4
apatrick_chromium
On 2011/08/17 00:09:52, vangelis wrote: > On 2011/08/16 21:31:18, apatrick_chromium wrote: > > I could ...
9 years, 4 months ago (2011-08-17 00:16:09 UTC) #5
apatrick_chromium
I found that Chrome has some standard process exit codes and there is one for ...
9 years, 4 months ago (2011-08-18 18:07:14 UTC) #6
vangelis
9 years, 4 months ago (2011-08-18 18:11:30 UTC) #7
On 2011/08/18 18:07:14, apatrick_chromium wrote:
> I found that Chrome has some standard process exit codes and there is one for
> hangs.

Oh, that's good.  With some luck we will catch the hangs in histograms recorded
at
GpuProcessHost::OnChildDied()

Powered by Google App Engine
This is Rietveld 408576698