Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: content/browser/download/download_file_manager.h

Issue 7646025: Detect file system errors during downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged with trunk. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_file_manager.h
diff --git a/content/browser/download/download_file_manager.h b/content/browser/download/download_file_manager.h
index 45cef5ea3f1d076b3eb51975b37a6ba2903816eb..7530bbad50385331d0a266b1113a9128f21f81cc 100644
--- a/content/browser/download/download_file_manager.h
+++ b/content/browser/download/download_file_manager.h
@@ -81,14 +81,14 @@ class DownloadFileManager
// Handlers for notifications sent from the IO thread and run on the
// FILE thread.
void UpdateDownload(int id, DownloadBuffer* buffer);
- // |os_error| is 0 for normal completions, and non-0 for errors.
+ // |net_error| is 0 for normal completions, and non-0 for errors.
// |security_info| contains SSL information (cert_id, cert_status,
// security_bits, ssl_connection_status), which can be used to
// fine-tune the error message. It is empty if the transaction
// was not performed securely.
void OnResponseCompleted(int id,
DownloadBuffer* buffer,
- int os_error,
+ int net_error,
const std::string& security_info);
// Handlers for notifications sent from the UI thread and run on the
@@ -147,7 +147,8 @@ class DownloadFileManager
// Called only from RenameInProgressDownloadFile and
// RenameCompletingDownloadFile on the FILE thread.
- void CancelDownloadOnRename(int id);
+ // |rename_error| indicates what error caused the cancel.
cbentzel 2011/08/19 18:44:21 Mention that it's a net::error
ahendrickson 2011/08/22 14:53:30 Done.
+ void CancelDownloadOnRename(int id, int rename_error);
// Erases the download file with the given the download |id| and removes
// it from the maps.

Powered by Google App Engine
This is Rietveld 408576698