Detect file system errors during downloads.

chrome/browser/download/download_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadManager object manages the process of downloading, including
 // updates to the history system and providing the information for displaying
 // the downloads view in the Destinations tab. There is one DownloadManager per
 // active profile in Chrome.
 //
 // Download observers:
@@ skipping 98 matching lines @@
   // Returns all non-temporary downloads matching |query|. Empty query matches
   // everything.
   void SearchDownloads(const string16& query, DownloadVector* result);
 
   // Returns true if initialized properly.
   bool Init(Profile* profile);
 
   // Notifications sent from the download thread to the UI thread
   void StartDownload(int32 id);
   void UpdateDownload(int32 download_id, int64 size);
+
+  // |download_id| is the ID of the download.
+  // |size| is the number of bytes that are currently downloaded.
   // |hash| is sha256 hash for the downloaded file. It is empty when the hash
   // is not available.
-  void OnResponseCompleted(int32 download_id, int64 size, int os_error,
+  void OnResponseCompleted(int32 download_id, int64 size,
                            const std::string& hash);
 
   // Called from a view when a user clicks a UI button or link.
   void DownloadCancelled(int32 download_id);
+
+  // Called when there is an error in the download.
+  // |download_id| is the ID of the download.
+  // |size| is the number of bytes that are currently downloaded.

[cbentzel, 2011/08/16 15:50:36]

that were downloaded at the time of the interruption, maybe?

is |error| a download error code, or a net_error code?

[ahendrickson, 2011/08/18 21:52:01]

Yes.  Changed.
ATM, it's a net_error code.  Eventually it will be a DownloadError.

+  // |error| is a download error code.  Indicates what caused the interruption.
+  void OnDownloadError(int32 download_id, int64 size, int error);
+
   void RemoveDownload(int64 download_handle);
 
   // Determine if the download is ready for completion, i.e. has had
   // all data saved, and completed the filename determination and
   // history insertion.
   bool IsDownloadReadyForCompletion(DownloadItem* download);
 
   // If all pre-requisites have been met, complete download processing, i.e.
   // do internal cleanup, file rename, and potentially auto-open.
   // (Dangerous downloads still may block on user acceptance after this
@@ skipping 198 matching lines @@
   // Called back after a target path for the file to be downloaded to has been
   // determined, either automatically based on the suggested file name, or by
   // the user in a Save As dialog box.
   void ContinueDownloadWithPath(DownloadItem* download,
                                 const FilePath& chosen_file);
 
   // Download cancel helper function.
   void DownloadCancelledInternal(int download_id,
                                  const DownloadRequestHandle& request_handle);
 
-  // All data has been downloaded.
-  // |hash| is sha256 hash for the downloaded file. It is empty when the hash
-  // is not available.
-  void OnAllDataSaved(int32 download_id, int64 size, const std::string& hash);
+  // Retrieves the download from the |download_id|.
+  // Returns NULL if the download is not active.
+  DownloadItem* GetActiveDownload(int32 download_id);
 
-  // An error occurred in the download.
-  void OnDownloadError(int32 download_id, int64 size, int os_error);
+  // Removes |download| from the active and in progress maps.
+  // Called when the download is cancelled or has an error.
+  // Does nothing if the download is not in the history DB.
+  void RemoveFromActiveList(DownloadItem* download);
 
   // Updates the app icon about the overall download progress.
   void UpdateAppIcon();
 
   // Inform observers that the model has changed.
   void NotifyModelChanged();
 
   // Get the download item from the active map.  Useful when the item is not
   // yet in the history map.
   DownloadItem* GetActiveDownloadItem(int id);
@@ skipping 79 matching lines @@
 
   scoped_ptr<OtherDownloadManagerObserver> other_download_manager_observer_;
 
   // Allows an embedder to control behavior. Guaranteed to outlive this object.
   DownloadManagerDelegate* delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadManager);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_H_