Detect file system errors during downloads.

chrome/browser/download/download_file_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/message_loop.h"
 #include "base/scoped_temp_dir.h"
 #include "base/string_number_conversions.h"
 #include "chrome/browser/download/download_create_info.h"
 #include "chrome/browser/download/download_file.h"
@@ skipping 21 matching lines @@
   // We need a UI |BrowserThread| in order to destruct |download_manager_|,
   // which has trait |BrowserThread::DeleteOnUIThread|.  Without this,
   // calling Release() on |download_manager_| won't ever result in its
   // destructor being called and we get a leak.
   DownloadFileTest() :
       ui_thread_(BrowserThread::UI, &loop_),
       file_thread_(BrowserThread::FILE, &loop_) {
   }
 
   ~DownloadFileTest() {
+    // Need to destroy the |DownloadFile| before |file_thread_|.
+    download_file_.reset(NULL);

[cbentzel, 2011/08/16 15:50:36]

Was this a leak? Why is this needed now?

[ahendrickson, 2011/08/18 21:52:01]

I did need that at one point, but it doesn't look like it's needed any more.

Removed.

   }
 
   virtual void SetUp() {
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
     download_manager_delegate_.reset(new MockDownloadManagerDelegate());
     download_manager_ = new MockDownloadManager(
         download_manager_delegate_.get(), &download_status_updater_);
   }
 
   virtual void TearDown() {
@@ skipping 135 matching lines @@
   // Check the files.
   EXPECT_FALSE(file_util::PathExists(path_3));
   EXPECT_TRUE(file_util::PathExists(path_4));
 
   // Check the hash.
   EXPECT_TRUE(download_file_->GetSha256Hash(&hash));
   EXPECT_EQ(kDataHash, base::HexEncode(hash.data(), hash.size()));
 
   DestroyDownloadFile(&download_file_, 0);
 }