Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 7646012: Build clang --without-llvmgcc and --without-llvmgxx (Closed)

Created:
9 years, 4 months ago by Mark Mentovai
Modified:
9 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, fischman+watch_chromium.org, pam+watch_chromium.org, ukai+watch_chromium.org
Visibility:
Public.

Description

Build clang --without-llvmgcc and --without-llvmgxx. Without this, configure finds llvm-gcc and llvm-g++ if already installed on the system, which will likely be out of date relative to the LLVM being built. This causes "make check" to run additional tests using the system llvm-gcc and llvm-g++. Some of these tests will fail. Since we don't build or care about llvm-gcc, it's pointless to run these tests, and it's scary to run your compiler's test suite and see failures. BUG=none TEST=cd third_party/llvm-build; make check-all; make unittests for i in tools/clang/unittests/*/Release+Asserts/*Tests; do "${i}"; done Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/clang/scripts/update.sh View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
Since we’ll be using this for production, I’d like to at least be able to ...
9 years, 4 months ago (2011-08-14 21:44:05 UTC) #1
Nico
I always run `make test` in llvm/tools/clang, and don't see errors. Where do you run ...
9 years, 4 months ago (2011-08-14 21:54:46 UTC) #2
Mark Mentovai
9 years, 4 months ago (2011-08-14 22:29:19 UTC) #3
thakis@chromium.org wrote:
> I always run `make test` in llvm/tools/clang, and don't see errors. Where do
> you run `make check`? llvm?

Yes, in llvm.

Running “make check-all” in llvm runs all of the LLVM (equivalent to
“make check” in llvm) and all of the clang (equivalent to “make test”
in llvm/tools/clang) tests.

Powered by Google App Engine
This is Rietveld 408576698