Fix MetricsServiceTest.CloseRenderersNormally flakiness.

Fix MetricsServiceTest.CloseRenderersNormally flakiness.

Fix by disabling the Instant field trial.

BUG=92635
TEST=MetricsServiceTest.CloseRenderersNormally


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96805

[sreeram, 2011-08-13 21:39:43]

Please review.

[sreeram, 2011-08-15 02:08:55]

+jar, +rtenetti

[ramant (doing other things), 2011-08-15 16:05:34]

LGTM.

[Paweł Hajdan Jr., 2011-08-15 16:27:58]

Thank you for fixing flakiness.

However, I think that this patch is just an invite for whack-a-mole with test
flakiness caused by random field trials.

How about disabling field trials for all large tests? You can do that in
test_launcher_utils.

[sreeram, 2011-08-15 16:57:10]

On Mon, Aug 15, 2011 at 09:27,  <phajdan.jr@chromium.org> wrote:
> However, I think that this patch is just an invite for whack-a-mole with
> test
> flakiness caused by random field trials.
>
> How about disabling field trials for all large tests? You can do that in
> test_launcher_utils.

Fair enough. I'll let this patch go through for the moment. I had
already clicked "Commit" before you responded, and am loathe to
uncheck the box now. Instead, I'll make a separate patch which
disables field trials in all tests. There are a couple of other places
that the field trial is currently being disabled in this manner, so it
will be a good opportunity to clean up all of them.

[commit-bot: I haz the power, 2011-08-15 19:15:43]

Change committed as 96805

[sreeram, 2011-08-15 21:50:09]

On Mon, Aug 15, 2011 at 09:56, Sreeram Ramachandran
<sreeram@chromium.org> wrote:
> On Mon, Aug 15, 2011 at 09:27,  <phajdan.jr@chromium.org> wrote:
>> However, I think that this patch is just an invite for whack-a-mole with
>> test
>> flakiness caused by random field trials.
>>
>> How about disabling field trials for all large tests? You can do that in
>> test_launcher_utils.
>
> Fair enough. I'll let this patch go through for the moment. I had
> already clicked "Commit" before you responded, and am loathe to
> uncheck the box now. Instead, I'll make a separate patch which
> disables field trials in all tests. There are a couple of other places
> that the field trial is currently being disabled in this manner, so it
> will be a good opportunity to clean up all of them.

I looked at the other places this pref was being set. I'm able to
remove one call site, cf: http://codereview.chromium.org/7649030/,
which leaves just the one in this test (metrics_service_ui_test) and
another in pyauto functional tests (instant.py). Given that there are
only two such instances, I don't feel it's necessary to move this pref
to test_launcher_utils just yet, mainly because it seems premature to
set this pref for all tests, but also because it still won't help the
situation with the instant.py test.

[Paweł Hajdan Jr., 2011-08-16 17:33:23]

On 2011/08/15 21:50:09, sreeram wrote:
> On Mon, Aug 15, 2011 at 09:56, Sreeram Ramachandran
> <mailto:sreeram@chromium.org> wrote:
> Given that there are
> only two such instances, I don't feel it's necessary to move this pref
> to test_launcher_utils just yet, mainly because it seems premature to
> set this pref for all tests, but also because it still won't help the
> situation with the instant.py test.

Yeah, I'm pretty sure it's better and more effective to spend even more time on
fixing tests one-by-one and spent more time on an already known problem.

Please add the flag to test_launcher utils, Just Do It. Thanks. ;-)