Issue 7645032: Profiles: Fix ZOOM_LEVEL_CHANGE overlisten in mac code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7645032: Profiles: Fix ZOOM_LEVEL_CHANGE overlisten in mac code. (Closed)

Created:
9 years, 4 months ago by Elliot Glaysher

Modified:
9 years, 4 months ago

Reviewers:
Robert Sesek, commit-bot: I haz the power

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Profiles: Fix ZOOM_LEVEL_CHANGE overlisten in mac code. BUG=87457 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97083

Patch Set 3 : Remove extra ')' #

Patch Set 4 : Check the context specifically. #

Total comments: 1

Patch Set 5 : {} #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm	View	1 2 3 4	3 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

LGTM http://codereview.chromium.org/7645032/diff/5002/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm File chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm (right): http://codereview.chromium.org/7645032/diff/5002/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm#newcode49 chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm:49: Source<HostZoomMap>(source).ptr()) nit: Wrapped ifs should have {}

9 years, 4 months ago (2011-08-16 21:18:00 UTC) #2

Change committed as 97083