Issue 7645026: Fix missing cursors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7645026: Fix missing cursors. (Closed)

Created:
9 years, 4 months ago by Avi (use Gerrit)

Modified:
9 years, 4 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix missing cursors. BUG=92845 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96803

Patch Set 1 #

Total comments: 6

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -6 lines)			Patch
	M	webkit/glue/webcursor_mac.mm	View		6 chunks	+60 lines, -6 lines	6 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM http://codereview.chromium.org/7645026/diff/1/webkit/glue/webcursor_mac.mm File webkit/glue/webcursor_mac.mm (right): http://codereview.chromium.org/7645026/diff/1/webkit/glue/webcursor_mac.mm#newcode27 webkit/glue/webcursor_mac.mm:27: // Forward-declare symbols that are part of the ...

9 years, 4 months ago (2011-08-15 16:00:08 UTC) #2

Avi (use Gerrit)

9 years, 4 months ago (2011-08-15 16:09:34 UTC) #3

http://codereview.chromium.org/7645026/diff/1/webkit/glue/webcursor_mac.mm
File webkit/glue/webcursor_mac.mm (right):

http://codereview.chromium.org/7645026/diff/1/webkit/glue/webcursor_mac.mm#ne...
webkit/glue/webcursor_mac.mm:27: // Forward-declare symbols that are part of the
10.6 SDK.
On 2011/08/15 16:00:08, Mark Mentovai wrote:
> Nit: These are declarations, not really anything especially “forward” about
> them.

Done.

http://codereview.chromium.org/7645026/diff/1/webkit/glue/webcursor_mac.mm#ne...
webkit/glue/webcursor_mac.mm:32: + (NSCursor *)contextualMenuCursor;
On 2011/08/15 16:00:08, Mark Mentovai wrote:
> Nit: This file uses NSCursor* style, no space.

Done.

http://codereview.chromium.org/7645026/diff/1/webkit/glue/webcursor_mac.mm#ne...
webkit/glue/webcursor_mac.mm:203: // 10.5 SDK, but later SDKs note that it
really is available on 10.5.
On 2011/08/15 16:00:08, Mark Mentovai wrote:
> Just be sure you test this.

Tested.

Expand Messages | Collapse Messages