Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 7645015: Rip out code for logging cross-frame property accesses. (Closed)

Created:
9 years, 4 months ago by Nico
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Rip out code for logging cross-frame property accesses. This depends on RenderView overriding a method of WebFrameClient that was added in http://trac.webkit.org/changeset/56829 but subsequently removed in http://trac.webkit.org/changeset/56849 . Since the code has been nonfunctional for over 1 year, I figure it's safe to remove it. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96742

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -43 lines) Patch
M chrome/renderer/page_load_histograms.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/page_load_histograms.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/renderer/render_view.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_view.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/renderer/render_view_observer.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
I hope these histograms weren't used to make any decisions :-)
9 years, 4 months ago (2011-08-14 19:10:32 UTC) #1
abarth-chromium
LGTM These were part of an experiment we were running that we never finished.
9 years, 4 months ago (2011-08-14 21:03:10 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-14 21:08:13 UTC) #3
Presubmit check for 7645015-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/renderer/render_view.cc,content/renderer/render_view.h,content/renderer/render_view_observer.h

Powered by Google App Engine
This is Rietveld 408576698