Valgrind/Heapchecker: Check for accidental copy/paste in suppression files.

tools/valgrind/memcheck/PRESUBMIT.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details on the presubmit API built into gcl.
 """
 
 import re
@@ skipping 12 matching lines @@
   for f in filter(lambda x: sup_regex.search(x.LocalPath()),
                   input_api.AffectedFiles()):
     for line, line_num in zip(f.NewContents(),
                               xrange(1, len(f.NewContents()) + 1)):
       line = line.lstrip()
       if line.startswith('#') or not line:
         continue
 
       if skip_next_line:
         if skip_next_line == 'skip_suppression_name':
+          if 'insert_a_suppression_name_here' in line:
+            errors.append('"insert_a_suppression_name_here" is not a valid '
+                          'suppression name')
           if suppressions.has_key(line):
             if f.LocalPath() == suppressions[line][1]:
               errors.append('suppression with name "%s" at %s line %s '
                             'has already been defined at line %s' %
                             (line, f.LocalPath(), line_num,
                              suppressions[line][1]))
             else:
               errors.append('suppression with name "%s" at %s line %s '
                             'has already been defined at %s line %s' %
                             (line, f.LocalPath(), line_num,
@@ skipping 26 matching lines @@
   return []
 
 def CheckChangeOnUpload(input_api, output_api):
   return CheckChange(input_api, output_api)
 
 def CheckChangeOnCommit(input_api, output_api):
   return CheckChange(input_api, output_api)
 
 def GetPreferredTrySlaves():
   return ['linux_valgrind', 'mac_valgrind']