Issue 7640022: Update Chromoting's Disconnect window resources for Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7640022: Update Chromoting's Disconnect window resources for Windows. (Closed)

Created:
9 years, 4 months ago by garykac

Modified:
9 years, 4 months ago

Reviewers:
Sergey Ulanov, Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make Disconnect buttons wider to accomodate the hotkey info. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96621

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	remoting/host/plugin/host_plugin.rc	View	1	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jamie

I have absolutely no idea of these new numbers are correct :) On the assumption ...

9 years, 4 months ago (2011-08-12 21:19:44 UTC) #2

Sergey Ulanov

http://codereview.chromium.org/7640022/diff/3001/remoting/host/plugin/host_plugin.rc File remoting/host/plugin/host_plugin.rc (right): http://codereview.chromium.org/7640022/diff/3001/remoting/host/plugin/host_plugin.rc#newcode100 remoting/host/plugin/host_plugin.rc:100: DEFPUSHBUTTON "kDisconnectButton",IDC_DISCONNECT,30,38,108,14 Do we need to have size of ...

9 years, 4 months ago (2011-08-13 01:21:23 UTC) #3

Jamie

9 years, 4 months ago (2011-08-13 02:26:38 UTC) #4

http://codereview.chromium.org/7640022/diff/3001/remoting/host/plugin/host_pl...
File remoting/host/plugin/host_plugin.rc (right):

http://codereview.chromium.org/7640022/diff/3001/remoting/host/plugin/host_pl...
remoting/host/plugin/host_plugin.rc:100: DEFPUSHBUTTON  
"kDisconnectButton",IDC_DISCONNECT,30,38,108,14
On 2011/08/13 01:21:23, sergeyu wrote:
> Do we need to have size of the button fixed? Is it possible to change size of
> the button depending on the title? In some locales text may not fit on the
> button.

Coming to a CL near you in the not-too-distant future.

Expand Messages | Collapse Messages