Issue 7640021: Move some Chrome-specific code paths out of DownloadManager and into the delegate. Getting rid of...

Issue 7640021: Move some Chrome-specific code paths out of DownloadManager and into the delegate. Getting rid of... (Closed)

Created:
9 years, 4 months ago by jam

Modified:
9 years, 3 months ago

Reviewers:
noelutz, Paweł Hajdan Jr.

CC:
chromium-reviews, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., asanka

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move some Chrome-specific code paths out of DownloadManager and into the delegate. Getting rid of the grit dependency allows us to move the files to content. Specifically, I moved safe browsing and history integration out. The logic to create temporary file names, and to uniqify filenames in case of a collision, also moves out. This is in line with keeping only the core download code in content. BUG=82782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96793

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+432 lines, -417 lines)			Patch
M	chrome/browser/download/chrome_download_manager_delegate.h	View	1 2	1 chunk	+47 lines, -8 lines	0 comments	Download
M	chrome/browser/download/chrome_download_manager_delegate.cc	View	1 2	2 chunks	+306 lines, -18 lines	0 comments	Download
M	chrome/browser/download/download_item.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/download/download_manager.h	View		6 chunks	+11 lines, -42 lines	0 comments	Download
M	chrome/browser/download/download_manager.cc	View	1	9 chunks	+7 lines, -301 lines	0 comments	Download
M	chrome/browser/download/download_manager_delegate.h	View		2 chunks	+21 lines, -16 lines	0 comments	Download
M	chrome/browser/download/download_manager_unittest.cc	View	1 2	4 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/download/mock_download_manager_delegate.h	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/download/mock_download_manager_delegate.cc	View		2 chunks	+20 lines, -13 lines	0 comments	Download
M	chrome/browser/profiles/profile.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

rubber stamp LGTM http://codereview.chromium.org/7640021/diff/1006/chrome/browser/download/download_manager.h File chrome/browser/download/download_manager.h (right): http://codereview.chromium.org/7640021/diff/1006/chrome/browser/download/download_manager.h#newcode200 chrome/browser/download/download_manager.h:200: nit: I think it'd be slightly ...

9 years, 4 months ago (2011-08-12 22:08:45 UTC) #2

noelutz

9 years, 3 months ago (2011-09-09 22:34:31 UTC) #4

On 2011/08/18 19:13:28, rdsmith wrote:
> Making Asanka aware of this CL ....

Hey John,
I noticed that this changes removes the SafeBrowsing binary digest check
(sb_client->CheckDownloadHash).  Do you have any suggestions on how to integrate
that code back?

This check has to happen after the download is done because we need the hash
(sha256) of the downloaded content.

Thanks for your help.
Cheers,
noe.

Expand Messages | Collapse Messages