Browser should not crash when a page showing a quota infobar is closed/reloaded

chrome/browser/chrome_quota_permission_context.cc

Index: chrome/browser/chrome_quota_permission_context.cc
diff --git a/chrome/browser/chrome_quota_permission_context.cc b/chrome/browser/chrome_quota_permission_context.cc
index 93efece51acd674a685495c8a07062467121b147..d0ec8bc7990a48f8f59d56376d10d1dd169bca4b 100644
--- a/chrome/browser/chrome_quota_permission_context.cc
+++ b/chrome/browser/chrome_quota_permission_context.cc
@@ -48,10 +48,7 @@ class RequestQuotaInfoBarDelegate : public ConfirmInfoBarDelegate {
         callback_(callback) {}
 
  private:
-  virtual ~RequestQuotaInfoBarDelegate() {
-    // Make sure we've dispatched the callback.
-    DCHECK(!callback_.get());

[michaeln, 2011/08/15 17:51:05]

The fact that we're tripping on this DCHECK indicates something wasn't working
as expected. Is it really ok to just remove the check, or is more needed to
handle this case?

- is it ok to not run the callback, is the caller left hanging?
- is it ok to delete the calback on the UI thread instead of the IO thread?

Would it be better to call...

context_->DispatchCallbackOnIOThread(
   callback_.release(),    
   QuotaPermissionContext::kResponseCancelled);

... at this point?

-  }
+  virtual ~RequestQuotaInfoBarDelegate() {}
 
   virtual bool ShouldExpire(
       const content::LoadCommittedDetails& details)