Issue 7640012: v8: Pick the namespace alias 'i' from v8.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7640012: v8: Pick the namespace alias 'i' from v8.h. (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
mnaganov (inactive)

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

v8: Pick the namespace alias 'i' from v8.h. These files already include v8.h so they don't need to define the namespace alias again. Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: http://code.google.com/p/v8/source/detail?r=8919

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -26 lines)			Patch
M	src/d8.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/mksnapshot.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/preparser.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-accessors.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-circular-queue.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-log.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-log-stack-tracer.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-profile-generator.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-unbound-queue.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

mnaganov (inactive)

9 years, 4 months ago (2011-08-12 09:42:24 UTC) #2

On 2011/08/12 01:14:10, tfarina wrote:

LGTM, thanks!
I'll commit this.